Bug 118833 - WebKit should include remaining ANGLE source files
Summary: WebKit should include remaining ANGLE source files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P3 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-17 22:36 PDT by Alex Christensen
Modified: 2013-08-20 09:09 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.13 MB, patch)
2013-07-17 22:40 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-07-17 22:36:51 PDT 
WebGL on Windows requires ANGLE source files that were previously not included in the WebKit repository.  These files should be included.
Comment 1 Alex Christensen 2013-07-17 22:40:46 PDT 
Created attachment 206950 [details]
Patch
Comment 2 Alex Christensen 2013-07-17 23:25:12 PDT 
I'm not sure why it thinks the Visual Studio project files are binary, or if that's a problem.  For some reason the execute bits of the files are set.  Should I chmod everything before adding, after adding, or not at all?  It might be nice to keep as much in common with the ANGLE repository as possible, but I'll have to edit the project files.
Comment 3 Dean Jackson 2013-07-18 13:46:47 PDT 
Comment on attachment 206950 [details]
Patch

rs=me
Comment 4 WebKit Commit Bot 2013-07-18 14:11:17 PDT 
Comment on attachment 206950 [details]
Patch

Clearing flags on attachment: 206950

Committed r152863: <http://trac.webkit.org/changeset/152863>
Comment 5 WebKit Commit Bot 2013-07-18 14:11:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Dean Jackson 2013-07-20 15:26:26 PDT 
Rolled out in https://trac.webkit.org/r152946
Comment 7 Alex Christensen 2013-08-20 09:09:37 PDT 
This was added in r152863, rolled out in r152946, and correctly added again in r153064.