Bug 118801 – MediaPlayerPrivateAVFoundationCF::processNewAndRemovedTextTracks should be shared by ObjC and CF versions

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Brent Fulgham]

The code in MediaPlayerPrivateAVFoundationCF::processNewAndRemovedTextTracks is identical to the code in MediaPlayerPrivateAVFoundationObjC::processNewAndRemovedTextTracks.  The implementation should be lifted to the parent class.

[Radar WebKit Bug Importer]

<rdar://problem/14472043>

[Brent Fulgham]

Created attachment 207029 [details]
Patch

[Brent Fulgham]

It turns out that "clearTracks" was identical as well.

[WebKit Commit Bot]

Comment on attachment 207029 [details]
Patch

Clearing flags on attachment: 207029

Committed r152876: <http://trac.webkit.org/changeset/152876>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

This patch caused a build failure on Mountain Lion:

/Volumes/Data/slave/mountainlion-debug/build/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:908:115: error: format specifies type 'int' but the argument has type 'size_t' (aka 'unsigned long') [-Werror,-Wformat]
    LOG(Media, "MediaPlayerPrivateAVFoundation::processNewAndRemovedTextTracks(%p) - found %i text tracks", this, m_textTracks.size());
                                                                                           ~~                     ^~~~~~~~~~~~~~~~~~~
                                                                                           %zi
/Volumes/Data/slave/mountainlion-debug/build/WebKitBuild/Debug/usr/local/include/wtf/Assertions.h:344:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
1 error generated.

[Brent Fulgham]

(In reply to comment #6)
> This patch caused a build failure on Mountain Lion:
> 
> /Volumes/Data/slave/mountainlion-debug/build/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:908:115: error: format specifies type 'int' but the argument has type 'size_t' (aka 'unsigned long') [-Werror,-Wformat]
>     LOG(Media, "MediaPlayerPrivateAVFoundation::processNewAndRemovedTextTracks(%p) - found %i text tracks", this, m_textTracks.size());
>                                                                                            ~~                     ^~~~~~~~~~~~~~~~~~~
>                                                                                            %zi
> /Volumes/Data/slave/mountainlion-debug/build/WebKitBuild/Debug/usr/local/include/wtf/Assertions.h:344:94: note: expanded from macro 'LOG'
> #define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
>                                                                                              ^
> 1 error generated.

Thank you for fixing that!

http://trac.webkit.org/changeset/152884