WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
118800
Use toSVGMarkerElement() instead of static_cast<>
https://bugs.webkit.org/show_bug.cgi?id=118800
Summary
Use toSVGMarkerElement() instead of static_cast<>
Gyuyoung Kim
Reported
2013-07-17 08:52:40 PDT
Though there is toSVGMarkerElement(), some files still use static_cast<SVGMarkerElement*>. To remove all static_cast<> use, we need to change argument from SVGElement to Node.
Attachments
Patch
(4.96 KB, patch)
2013-07-17 08:54 PDT
,
Gyuyoung Kim
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1
2013-07-17 08:54:54 PDT
Created
attachment 206889
[details]
Patch
Gyuyoung Kim
Comment 2
2013-07-17 09:00:23 PDT
This patch can be built on debug build. I checked it locally. Besides this is being landed to blink as well.
https://codereview.chromium.org/19351003/
Gyuyoung Kim
Comment 3
2013-07-17 10:07:03 PDT
I will land this when I can check if debug buildbots are fine.
WebKit Commit Bot
Comment 4
2013-07-17 19:10:55 PDT
Comment on
attachment 206889
[details]
Patch Clearing flags on attachment: 206889 Committed
r152826
: <
http://trac.webkit.org/changeset/152826
>
WebKit Commit Bot
Comment 5
2013-07-17 19:10:59 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug