Bug 118797 – [EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_color_picker.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Donggwan Kim]

Some mouseClick methods are used in test_ewk2_color_picker.cpp.
But it is difficult to understand what they mean.
So i would like to replace those with more meaningful method for readability.

[Donggwan Kim]

Created attachment 206939 [details]
Patch

[Chris Dumez]

Comment on attachment 206939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206939&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:114
> +    void clickColorPicker(Visible visible)

This does not really click the color picker. It clicks a button. How about:
enum Button { ShowColorPickerButton, HideColorPickerButton };
clickButton(Button button);

[Donggwan Kim]

(In reply to comment #2)
> (From update of attachment 206939 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206939&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:114
> > +    void clickColorPicker(Visible visible)
> 
> This does not really click the color picker. It clicks a button. How about:
> enum Button { ShowColorPickerButton, HideColorPickerButton };
> clickButton(Button button);

Ok. I will change it like above

[Donggwan Kim]

Created attachment 206959 [details]
Patch

[Chris Dumez]

Comment on attachment 206959 [details]
Patch

Ok, r=me.

[WebKit Commit Bot]

Comment on attachment 206959 [details]
Patch

Clearing flags on attachment: 206959

Committed r152838: <http://trac.webkit.org/changeset/152838>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.