Bug 118796 - [EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_context_menu.cpp
Summary: [EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_contex...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-17 04:32 PDT by Donggwan Kim
Modified: 2013-07-18 01:00 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.17 KB, patch)
2013-07-17 17:49 PDT, Donggwan Kim
no flags Details | Formatted Diff | Diff
Patch (5.16 KB, patch)
2013-07-18 00:19 PDT, Donggwan Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Donggwan Kim 2013-07-17 04:32:29 PDT
Some mouseClick methods are used in test_ewk2_context_menu.cpp.
But it is difficult to understand what they mean.
So i would like to replace those with more meaningful method for readability.
Comment 1 Donggwan Kim 2013-07-17 17:49:06 PDT
Created attachment 206938 [details]
Patch
Comment 2 Chris Dumez 2013-07-18 00:09:41 PDT
Comment on attachment 206938 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206938&action=review

r=me.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:187
> +        mouseClick(10, 20, 3);

Please keep the /* Right */ comment.
Comment 3 Donggwan Kim 2013-07-18 00:19:13 PDT
Created attachment 206956 [details]
Patch
Comment 4 Donggwan Kim 2013-07-18 00:22:27 PDT
(In reply to comment #2)
> (From update of attachment 206938 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206938&action=review
> 
> r=me.
> 
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:187
> > +        mouseClick(10, 20, 3);
> 
> Please keep the /* Right */ comment.

Done
Comment 5 WebKit Commit Bot 2013-07-18 01:00:06 PDT
Comment on attachment 206956 [details]
Patch

Clearing flags on attachment: 206956

Committed r152835: <http://trac.webkit.org/changeset/152835>
Comment 6 WebKit Commit Bot 2013-07-18 01:00:09 PDT
All reviewed patches have been landed.  Closing bug.