Bug 118796 – [EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_context_menu.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Donggwan Kim]

Some mouseClick methods are used in test_ewk2_context_menu.cpp.
But it is difficult to understand what they mean.
So i would like to replace those with more meaningful method for readability.

[Donggwan Kim]

Created attachment 206938 [details]
Patch

[Chris Dumez]

Comment on attachment 206938 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206938&action=review

r=me.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:187
> +        mouseClick(10, 20, 3);

Please keep the /* Right */ comment.

[Donggwan Kim]

Created attachment 206956 [details]
Patch

[Donggwan Kim]

(In reply to comment #2)
> (From update of attachment 206938 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206938&action=review
> 
> r=me.
> 
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:187
> > +        mouseClick(10, 20, 3);
> 
> Please keep the /* Right */ comment.

Done

[WebKit Commit Bot]

Comment on attachment 206956 [details]
Patch

Clearing flags on attachment: 206956

Committed r152835: <http://trac.webkit.org/changeset/152835>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.