WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
118792
[EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_file_chooser_request.cpp
https://bugs.webkit.org/show_bug.cgi?id=118792
Summary
[EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_file_c...
Donggwan Kim
Reported
2013-07-17 04:27:25 PDT
Some mouseClick methods are used in test_ewk2_file_chooser_request.cpp. But it is difficult to understand what they mean. So i would like to replace those with more meaningful method for readability.
Attachments
Patch
(3.37 KB, patch)
2013-07-17 17:26 PDT
,
Donggwan Kim
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Donggwan Kim
Comment 1
2013-07-17 17:26:39 PDT
Created
attachment 206932
[details]
Patch
Chris Dumez
Comment 2
2013-07-18 00:13:56 PDT
Comment on
attachment 206932
[details]
Patch Not a huge difference but ok. r=me.
WebKit Commit Bot
Comment 3
2013-07-18 00:28:00 PDT
Comment on
attachment 206932
[details]
Patch Clearing flags on attachment: 206932 Committed
r152833
: <
http://trac.webkit.org/changeset/152833
>
WebKit Commit Bot
Comment 4
2013-07-18 00:28:02 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug