RESOLVED FIXED 118782
Remove Platform(EFL) guard from Widget::frameRectsChanged 
https://bugs.webkit.org/show_bug.cgi?id=118782
Summary Remove Platform(EFL) guard from Widget::frameRectsChanged
Ryuan Choi
Reported 2013-07-16 23:04:44 PDT
Since r58487, Widget::frameRectsChanged was moved to cpp and guarded. But we can move back to header because WebKit/Efl refactored related code in r145710.
Attachments
Patch (2.55 KB, patch)
2013-07-16 23:09 PDT, Ryuan Choi 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2013-07-16 23:09:45 PDT
Created attachment 206857 [details] Patch
Chris Dumez
Comment 2 2013-07-16 23:34:44 PDT
Comment on attachment 206857 [details] Patch Minor refactoring, looks fine. r=me.
Chris Dumez
Comment 3 2013-07-16 23:35:52 PDT
Comment on attachment 206857 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206857&action=review > Source/WebCore/ChangeLog:13 > + * platform/Widget.cpp: Removed platform guard and move frameRectsChangd() back to header. typo: "frameRectsChanged()"
Ryuan Choi
Comment 4 2013-07-16 23:49:59 PDT
(In reply to comment #3) > (From update of attachment 206857 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206857&action=review > > > Source/WebCore/ChangeLog:13 > > + * platform/Widget.cpp: Removed platform guard and move frameRectsChangd() back to header. > > typo: "frameRectsChanged()" Sorry, I cut the shell but it was late. Patch was already landed. http://trac.webkit.org/log/trunk?rev=152757 I will watch more next time.
Note You need to log in before you can comment on or make changes to this bug.