Bug 118782 - Remove Platform(EFL) guard from Widget::frameRectsChanged
Summary: Remove Platform(EFL) guard from Widget::frameRectsChanged
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-16 23:04 PDT by Ryuan Choi
Modified: 2013-07-16 23:49 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.55 KB, patch)
2013-07-16 23:09 PDT, Ryuan Choi
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2013-07-16 23:04:44 PDT
Since r58487, Widget::frameRectsChanged was moved to cpp and guarded.
But we can move back to header because WebKit/Efl refactored related code in r145710.
Comment 1 Ryuan Choi 2013-07-16 23:09:45 PDT
Created attachment 206857 [details]
Patch
Comment 2 Chris Dumez 2013-07-16 23:34:44 PDT
Comment on attachment 206857 [details]
Patch

Minor refactoring, looks fine. r=me.
Comment 3 Chris Dumez 2013-07-16 23:35:52 PDT
Comment on attachment 206857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206857&action=review

> Source/WebCore/ChangeLog:13
> +        * platform/Widget.cpp: Removed platform guard and move frameRectsChangd() back to header.

typo: "frameRectsChanged()"
Comment 4 Ryuan Choi 2013-07-16 23:49:59 PDT
(In reply to comment #3)
> (From update of attachment 206857 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206857&action=review
> 
> > Source/WebCore/ChangeLog:13
> > +        * platform/Widget.cpp: Removed platform guard and move frameRectsChangd() back to header.
> 
> typo: "frameRectsChanged()"

Sorry, I cut the shell but it was late.
Patch was already landed. http://trac.webkit.org/log/trunk?rev=152757

I will watch more next time.