Bug 118778 - fourthTier: Add a phase to create loop pre-headers
Summary: fourthTier: Add a phase to create loop pre-headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 118749
  Show dependency tree / graph
 
Reported: 2013-07-16 22:18 PDT by Filip Pizlo
Modified: 2013-07-17 22:15 PDT (History)
7 users (show)

See Also:

Attachments
the patch (20.29 KB, patch)
2013-07-16 22:24 PDT, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-07-16 22:18:36 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-07-16 22:24:48 PDT 
Created attachment 206854 [details]
the patch
Comment 2 Geoffrey Garen 2013-07-17 13:23:52 PDT 
Comment on attachment 206854 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206854&action=review

> Source/JavaScriptCore/dfg/DFGNaturalLoops.h:63
> +    // a natural loop. It's faster to call 

The suspense is killing me. Faster to call what?
Comment 3 Filip Pizlo 2013-07-17 14:02:13 PDT 
Comment on attachment 206854 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206854&action=review

>> Source/JavaScriptCore/dfg/DFGNaturalLoops.h:63
>> +    // a natural loop. It's faster to call 
> 
> The suspense is killing me. Faster to call what?

Lol.  It's faster to call NaturalLoops::belongsTo().  I'll fix that comment.
Comment 4 Filip Pizlo 2013-07-17 22:15:09 PDT 
Landed in http://trac.webkit.org/changeset/152829