Allow RenderGeometryMap to map using layers more often

[Simon Fraser (smfr)]

I think we can do this:

diff --git a/Source/WebCore/rendering/RenderGeometryMap.cpp b/Source/WebCore/rendering/RenderGeometryMap.cpp
index 4513ef6a16ca306cdcbe4cb3009642f113cbcf05..9cef31041780fc82788de0872b4beae42f824891 100644
--- a/Source/WebCore/rendering/RenderGeometryMap.cpp
+++ b/Source/WebCore/rendering/RenderGeometryMap.cpp
@@ -165,9 +165,12 @@ static bool canMapBetweenRenderers(const RenderObject* renderer, const RenderObj
         if (style->position() == FixedPosition || style->isFlippedBlocksWritingMode())
             return false;
         
-        if (current->hasColumns() || current->hasTransform() || current->isRenderFlowThread())
+        if (current->hasColumns() || current->isRenderFlowThread())
             return false;
 
+        if (current->hasTransform() && toRenderLayerModelObject(current)->layer()->transform() && !toRenderLayerModelObject(current)->layer()->transform()->isIdentity())
+             return false;
+
     #if ENABLE(SVG)
         if (current->isSVGRoot())
             return false;

[Simon Fraser (smfr)]

Created attachment 206893 [details]
Patch

[Tim Horton]

Comment on attachment 206893 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206893&action=review

> Source/WebCore/rendering/RenderGeometryMap.cpp:171
> +        if (current->hasTransform() && toRenderLayerModelObject(current)->layer()->transform() && !toRenderLayerModelObject(current)->layer()->transform()->isIdentity())

Could totally factor out "toRenderLayerModelObject(current)->layer()->transform()".

[Simon Fraser (smfr)]

Comment on attachment 206893 [details]
Patch

Hmm, not sure this will do the correct thing if the transform is being animated.

[Csaba Osztrogonác]

Comment on attachment 206893 [details]
Patch

Cleared Tim Horton's review+ from obsolete attachment 206893 [details] so that this bug does not appear in http://webkit.org/pending-commit.