Bug 118754 - AX: aria-required.html needs to test @required vs @aria-required mismatch reconciliation
Summary: AX: aria-required.html needs to test @required vs @aria-required mismatch rec...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: James Craig
URL:
Keywords: InRadar
Depends on:
Blocks: 119988
  Show dependency tree / graph
 
Reported: 2013-07-16 16:27 PDT by James Craig
Modified: 2013-08-19 17:52 PDT (History)
10 users (show)

See Also:

Attachments
patch (12.09 KB, patch)
2013-08-18 17:59 PDT, James Craig 		darin: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (522.07 KB, application/zip)
2013-08-18 22:08 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (787.72 KB, application/zip)
2013-08-19 07:40 PDT, Build Bot 		no flags Details
patch with review feedback IDREF changes (13.13 KB, patch)
2013-08-19 08:35 PDT, James Craig 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2013-07-16 16:27:28 PDT 
AX: aria-required.html needs to test @required vs @aria-required mismatch reconciliation
LayoutTests/accessibility/aria-required.html

The readonly test provides more coverage of the @readonly vs @aria-readonly mismatch reconciliation. Update the @required one to match.
LayoutTests/accessibility/aria-readonly.html
Comment 1 Radar WebKit Bug Importer 2013-07-16 16:27:57 PDT 
<rdar://problem/14462302>
Comment 2 James Craig 2013-08-18 17:59:03 PDT 
Created attachment 209044 [details]
patch
Comment 3 Darin Adler 2013-08-18 19:37:23 PDT 
Comment on attachment 209044 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209044&action=review

> LayoutTests/accessibility/aria-required-expected.txt:8
> +PASS textfield1 isRequired is false

This is an improvement, but this test is sill deficient. Normally we try to put as much as possible in the expressions that are logged to make clear what's being tested, choosing names that express what's going on. The names here do not make it clear enough what is being tested, so the test output is sufficiently readable. There is nothing here that helps me understand why "textfield1" should not be required, but textfield2 should be.
Comment 4 Build Bot 2013-08-18 22:08:46 PDT 
Comment on attachment 209044 [details]
patch

Attachment 209044 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1502610

New failing tests:
accessibility/aria-required.html
Comment 5 Build Bot 2013-08-18 22:08:49 PDT 
Created attachment 209054 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.4
Comment 6 Build Bot 2013-08-19 07:40:24 PDT 
Comment on attachment 209044 [details]
patch

Attachment 209044 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1518204

New failing tests:
accessibility/aria-required.html
Comment 7 Build Bot 2013-08-19 07:40:27 PDT 
Created attachment 209086 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4
Comment 8 James Craig 2013-08-19 08:35:04 PDT 
Created attachment 209091 [details]
patch with review feedback IDREF changes
Comment 9 WebKit Commit Bot 2013-08-19 17:51:58 PDT 
Comment on attachment 209091 [details]
patch with review feedback IDREF changes

Clearing flags on attachment: 209091

Committed r154309: <http://trac.webkit.org/changeset/154309>
Comment 10 WebKit Commit Bot 2013-08-19 17:52:01 PDT 
All reviewed patches have been landed.  Closing bug.