Bug 118754 – AX: aria-required.html needs to test @required vs @aria-required mismatch reconciliation

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[James Craig]

AX: aria-required.html needs to test @required vs @aria-required mismatch reconciliation
LayoutTests/accessibility/aria-required.html

The readonly test provides more coverage of the @readonly vs @aria-readonly mismatch reconciliation. Update the @required one to match.
LayoutTests/accessibility/aria-readonly.html

[Radar WebKit Bug Importer]

<rdar://problem/14462302>

[James Craig]

Created attachment 209044 [details]
patch

[Darin Adler]

Comment on attachment 209044 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209044&action=review

> LayoutTests/accessibility/aria-required-expected.txt:8
> +PASS textfield1 isRequired is false

This is an improvement, but this test is sill deficient. Normally we try to put as much as possible in the expressions that are logged to make clear what's being tested, choosing names that express what's going on. The names here do not make it clear enough what is being tested, so the test output is sufficiently readable. There is nothing here that helps me understand why "textfield1" should not be required, but textfield2 should be.

[Build Bot]

Comment on attachment 209044 [details]
patch

Attachment 209044 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1502610

New failing tests:
accessibility/aria-required.html

[Build Bot]

Created attachment 209054 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.4

[Build Bot]

Comment on attachment 209044 [details]
patch

Attachment 209044 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1518204

New failing tests:
accessibility/aria-required.html

[Build Bot]

Created attachment 209086 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

[James Craig]

Created attachment 209091 [details]
patch with review feedback IDREF changes

[WebKit Commit Bot]

Comment on attachment 209091 [details]
patch with review feedback IDREF changes

Clearing flags on attachment: 209091

Committed r154309: <http://trac.webkit.org/changeset/154309>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.