Bug 118753 - Typo in DFGInsertionSet.h header guard: "DFGInsectionSet_h" -> "DFGInsertionSet_h"
Summary: Typo in DFGInsertionSet.h header guard: "DFGInsectionSet_h" -> "DFGInsertionS...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: David Farler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-16 16:18 PDT by David Farler
Modified: 2013-07-16 16:23 PDT (History)
0 users

See Also:

Attachments
Patch (1.14 KB, patch)
2013-07-16 16:20 PDT, David Farler 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Farler 2013-07-16 16:18:02 PDT 
DFGInsertionSet.h:

 26 #ifndef DFGInsertionSet_h                                                                                                                                                            
 27 #define DFGInsectionSet_h                                                                                                                                                            

Found this with trunk clang [-Wheader-guard]

In file included from /webkit/OpenSource/Source/JavaScriptCore/dfg/DFGDCEPhase.cpp:33:
/webkit/OpenSource/Source/JavaScriptCore/dfg/DFGInsertionSet.h:26:9: error: 'DFGInsertionSet_h' is used as a header guard here, followed by #define of a different macro [-Werror,-Wheader-guard]
#ifndef DFGInsertionSet_h
        ^~~~~~~~~~~~~~~~~
/webkit/OpenSource/Source/JavaScriptCore/dfg/DFGInsertionSet.h:27:9: note: 'DFGInsectionSet_h' is defined here; did you mean 'DFGInsertionSet_h'?
#define DFGInsectionSet_h
        ^~~~~~~~~~~~~~~~~
        DFGInsertionSet_h
1 error generated.
Comment 1 David Farler 2013-07-16 16:20:21 PDT 
Created attachment 206824 [details]
Patch
Comment 2 Geoffrey Garen 2013-07-16 16:22:22 PDT 
Comment on attachment 206824 [details]
Patch

r=me
Comment 3 David Farler 2013-07-16 16:23:10 PDT 
Committed r152747: <http://trac.webkit.org/changeset/152747>