RESOLVED FIXED 118750
fourthTier: NaturalLoops should be able to quickly answer questions like "what loops own this basic block" 
https://bugs.webkit.org/show_bug.cgi?id=118750
Summary fourthTier: NaturalLoops should be able to quickly answer questions like "wha...
Filip Pizlo
Reported 2013-07-16 14:52:19 PDT
Patch forthcoming.
Attachments
the patch (8.69 KB, patch)
2013-07-16 15:11 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (10.51 KB, patch)
2013-07-16 15:36 PDT, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-07-16 15:11:55 PDT
Created attachment 206817 [details] the patch
Filip Pizlo
Comment 2 2013-07-16 15:36:12 PDT
Created attachment 206819 [details] the patch
Mark Hahnenberg
Comment 3 2013-07-16 15:47:58 PDT
Comment on attachment 206819 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=206819&action=review r=me with comments. > Source/JavaScriptCore/dfg/DFGNaturalLoops.cpp:190 > + ASSERT(simpleLoopsOf == fancyLoopsOf); RELEASE_ASSERT > Source/JavaScriptCore/dfg/DFGNaturalLoops.h:116 > + for ( > + const NaturalLoop* loop = innerMostLoopOf(block); > + loop; > + loop = innerMostOuterLoop(*loop)) { > + if (loop->header() == block) > + return loop; Don't need to for-loop. Modified version looks good. > Source/JavaScriptCore/dfg/DFGPlan.cpp:192 > + // to self-validate. Now is as good a time as any, to do this. No comma :-)
Filip Pizlo
Comment 4 2013-07-16 15:49:46 PDT
Landed in http://trac.webkit.org/changeset/152745
Note You need to log in before you can comment on or make changes to this bug.