fourthTier: NaturalLoops should be able to quickly answer questions like "what loops own this basic block"

[Filip Pizlo]

Patch forthcoming.

[Filip Pizlo]

Created attachment 206817 [details]
the patch

[Filip Pizlo]

Created attachment 206819 [details]
the patch

[Mark Hahnenberg]

Comment on attachment 206819 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206819&action=review

r=me with comments.

> Source/JavaScriptCore/dfg/DFGNaturalLoops.cpp:190
> +            ASSERT(simpleLoopsOf == fancyLoopsOf);

RELEASE_ASSERT

> Source/JavaScriptCore/dfg/DFGNaturalLoops.h:116
> +        for (
> +            const NaturalLoop* loop = innerMostLoopOf(block);
> +            loop;
> +            loop = innerMostOuterLoop(*loop)) {
> +            if (loop->header() == block)
> +                return loop;

Don't need to for-loop. Modified version looks good.

> Source/JavaScriptCore/dfg/DFGPlan.cpp:192
> +    // to self-validate. Now is as good a time as any, to do this.

No comma :-)

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/152745