Bug 118745 - MakeRope fixup shouldn't lead to an Identity without kids
Summary: MakeRope fixup shouldn't lead to an Identity without kids
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-07-16 12:35 PDT by Filip Pizlo
Modified: 2013-07-16 14:40 PDT (History)
9 users (show)

See Also:

Attachments
the patch (3.70 KB, patch)
2013-07-16 12:37 PDT, Filip Pizlo 		mhahnenberg: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (755.67 KB, application/zip)
2013-07-16 13:38 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-07-16 12:35:08 PDT 
Patch forthcoming.

<rdar://problem/14202134>
Comment 1 Filip Pizlo 2013-07-16 12:37:36 PDT 
Created attachment 206807 [details]
the patch

I am still running tests to create expected.txt file for the new test.
Comment 2 Mark Hahnenberg 2013-07-16 12:38:40 PDT 
Comment on attachment 206807 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206807&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        Make the empty string pruning park of fixupMakeRope() stop if it's on the last child.

s/park/part/
Comment 3 Mark Hahnenberg 2013-07-16 12:39:11 PDT 
Comment on attachment 206807 [details]
the patch

r=me with test expectation.
Comment 4 Build Bot 2013-07-16 13:38:46 PDT 
Comment on attachment 206807 [details]
the patch

Attachment 206807 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1085304

New failing tests:
fast/js/dfg-make-rope-all-empty-strings.html
Comment 5 Build Bot 2013-07-16 13:38:48 PDT 
Created attachment 206811 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.3
Comment 6 Filip Pizlo 2013-07-16 14:40:03 PDT 
Landed in http://trac.webkit.org/changeset/152742