Bug 118742 – Missing break in WebGLRenderingContext::validateCompressedTexFuncData()

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Pratik Solanki]

WebGLRenderingContext::validateCompressedTexFuncData() has this code

    case Extensions3D::COMPRESSED_ATC_RGBA_EXPLICIT_ALPHA_AMD:
    case Extensions3D::COMPRESSED_ATC_RGBA_INTERPOLATED_ALPHA_AMD:
        {
            bytesRequired = floor(static_cast<double>((width + 3) / 4)) * floor(static_cast<double>((height + 3) / 4)) * 16;
        }
    case Extensions3D::COMPRESSED_RGB_PVRTC_4BPPV1_IMG:
    case Extensions3D::COMPRESSED_RGBA_PVRTC_4BPPV1_IMG:
        {
            bytesRequired = max(width, 8) * max(height, 8) / 2;
        }
        break;


It's missing a break for COMPRESSED_ATC_RGBA_EXPLICIT_ALPHA_AMD and COMPRESSED_ATC_RGBA_INTERPOLATED_ALPHA_AMD case.

[Pratik Solanki]

Created attachment 206800 [details]
Patch

[Build Bot]

Comment on attachment 206800 [details]
Patch

Attachment 206800 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1090299

New failing tests:
fullscreen/full-screen-iframe-with-max-width-height.html

[Build Bot]

Created attachment 206805 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Pratik Solanki]

The test fails for me with and without my patch so the patch isn't causing this failure.

[Pratik Solanki]

Committed r152750: <http://trac.webkit.org/changeset/152750>