Bug 118742 - Missing break in WebGLRenderingContext::validateCompressedTexFuncData()
Summary: Missing break in WebGLRenderingContext::validateCompressedTexFuncData()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-16 11:22 PDT by Pratik Solanki
Modified: 2013-07-16 17:33 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.45 KB, patch)
2013-07-16 11:24 PDT, Pratik Solanki 		rniwa: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (602.53 KB, application/zip)
2013-07-16 12:16 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2013-07-16 11:22:09 PDT 
WebGLRenderingContext::validateCompressedTexFuncData() has this code

    case Extensions3D::COMPRESSED_ATC_RGBA_EXPLICIT_ALPHA_AMD:
    case Extensions3D::COMPRESSED_ATC_RGBA_INTERPOLATED_ALPHA_AMD:
        {
            bytesRequired = floor(static_cast<double>((width + 3) / 4)) * floor(static_cast<double>((height + 3) / 4)) * 16;
        }
    case Extensions3D::COMPRESSED_RGB_PVRTC_4BPPV1_IMG:
    case Extensions3D::COMPRESSED_RGBA_PVRTC_4BPPV1_IMG:
        {
            bytesRequired = max(width, 8) * max(height, 8) / 2;
        }
        break;


It's missing a break for COMPRESSED_ATC_RGBA_EXPLICIT_ALPHA_AMD and COMPRESSED_ATC_RGBA_INTERPOLATED_ALPHA_AMD case.
Comment 1 Pratik Solanki 2013-07-16 11:24:36 PDT 
Created attachment 206800 [details]
Patch
Comment 2 Build Bot 2013-07-16 12:16:01 PDT 
Comment on attachment 206800 [details]
Patch

Attachment 206800 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1090299

New failing tests:
fullscreen/full-screen-iframe-with-max-width-height.html
Comment 3 Build Bot 2013-07-16 12:16:02 PDT 
Created attachment 206805 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.3
Comment 4 Pratik Solanki 2013-07-16 17:29:06 PDT 
The test fails for me with and without my patch so the patch isn't causing this failure.
Comment 5 Pratik Solanki 2013-07-16 17:33:07 PDT 
Committed r152750: <http://trac.webkit.org/changeset/152750>