Bug 118730 - [GTK] Regression: Multiple tests fail after r152701 changed how unavailable plugins are handled
Summary: [GTK] Regression: Multiple tests fail after r152701 changed how unavailable p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Pena
URL:
Keywords: Gtk, LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2013-07-16 06:33 PDT by Simon Pena
Modified: 2013-07-22 06:13 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.57 KB, patch)
2013-07-22 02:55 PDT, Simon Pena 		no flags Details | Formatted Diff | Diff
Patch (2.54 KB, patch)
2013-07-22 02:57 PDT, Simon Pena 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Pena 2013-07-16 06:33:19 PDT 
The following layout tests are failing on GTK after r152701 <http://trac.webkit.org/changeset/152701>

fast/replaced/border-radius-clip.html
http/tests/security/contentSecurityPolicy/1.1/plugintypes-invalid.html
http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-url.html
http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-02.html
plugins/embed-attributes-style.html
plugins/iframe-shims.html
editing/pasteboard/paste-noplugin.html

This one was previously passing, even if it was a WontFix, and now fails.
fast/images/object-image.html
Comment 1 Gábor Ábrahám 2013-07-17 06:01:49 PDT 
fast/images/object-image.html test fails on Qt WK2 too.
Comment 2 Simon Pena 2013-07-22 02:52:35 PDT 
The changes from r152701 were rolled out in r152814 <http://trac.webkit.org/changeset/152814> and later reworked in r152824 <http://trac.webkit.org/changeset/152824>, so these tests no longer fail. I'll submit a patch to unskip them.
Comment 3 Simon Pena 2013-07-22 02:55:39 PDT 
Created attachment 207232 [details]
Patch
Comment 4 Simon Pena 2013-07-22 02:57:52 PDT 
Created attachment 207233 [details]
Patch
Comment 5 WebKit Commit Bot 2013-07-22 06:13:56 PDT 
Comment on attachment 207233 [details]
Patch

Clearing flags on attachment: 207233

Committed r152965: <http://trac.webkit.org/changeset/152965>
Comment 6 WebKit Commit Bot 2013-07-22 06:13:58 PDT 
All reviewed patches have been landed.  Closing bug.