Bug 118727 - Use toHTMLMediaElement
Summary: Use toHTMLMediaElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kangil Han
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-16 04:04 PDT by Kangil Han
Modified: 2013-07-17 00:10 PDT (History)
4 users (show)

See Also:

Attachments
Patch (26.21 KB, patch)
2013-07-16 04:07 PDT, Kangil Han 		no flags Details | Formatted Diff | Diff
Patch (25.13 KB, patch)
2013-07-16 06:45 PDT, Kangil Han 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kangil Han 2013-07-16 04:04:17 PDT 
Use toHTMLMediaElement and remove isMediaElement
Comment 1 Kangil Han 2013-07-16 04:07:13 PDT 
Created attachment 206755 [details]
Patch
Comment 2 Ryosuke Niwa 2013-07-16 05:22:15 PDT 
Comment on attachment 206755 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206755&action=review

> Source/WebCore/html/HTMLTrackElement.cpp:90
> +    if (!parentNode() && insertionPoint->isElementNode() && toElement(insertionPoint)->isMediaElement())

I don't think removing isMediaElement is a good idea in this case.
Comment 3 Kangil Han 2013-07-16 06:45:35 PDT 
Created attachment 206776 [details]
Patch
Comment 4 Kangil Han 2013-07-16 06:46:18 PDT 
(In reply to comment #2)
> (From update of attachment 206755 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206755&action=review
> 
> > Source/WebCore/html/HTMLTrackElement.cpp:90
> > +    if (!parentNode() && insertionPoint->isElementNode() && toElement(insertionPoint)->isMediaElement())
> 
> I don't think removing isMediaElement is a good idea in this case.

Done, thx! :)
Took Ryosuke's comment into consideration.
Comment 5 WebKit Commit Bot 2013-07-17 00:10:55 PDT 
Comment on attachment 206776 [details]
Patch

Clearing flags on attachment: 206776

Committed r152763: <http://trac.webkit.org/changeset/152763>
Comment 6 WebKit Commit Bot 2013-07-17 00:10:57 PDT 
All reviewed patches have been landed.  Closing bug.