fast/regions/percentage-margins-variable-width-regions.html fast/regions/percentage-margins-rtl-variable-width-regions.html fast/regions/percentage-margins-mixed-rtl-dominant-regions.html fast/regions/percentage-margins-mixed-ltr-dominant-regions.html Should be ref tests
Created attachment 207239 [details] Patch
Comment on attachment 207239 [details] Patch Clearing flags on attachment: 207239 Committed r152968: <http://trac.webkit.org/changeset/152968>
All reviewed patches have been landed. Closing bug.
Re-opened since this is blocked by bug 118975
Created attachment 207308 [details] Patch
(In reply to comment #5) > Created an attachment (id=207308) [details] > Patch Looks good. I have 3 comments: -> using Ahem font, makes the test less readable, maybe you should add a description to the tests about the expected behavior? Or a note in changelog about what these tests are intended to check? -> I prefer to use the monospace font instead of Ahem, usually font: 16px/1.25 monospace, but it is just a preference. -> why are you using <span style="line-height: 100px;">XXXXXX</span> in *-expected.html files? Do you need them in all the boxes?
(In reply to comment #6) > (In reply to comment #5) > > Created an attachment (id=207308) [details] [details] > > Patch > > Looks good. I have 3 comments: > -> using Ahem font, makes the test less readable, maybe you should add a description to the tests about the expected behavior? Or a note in changelog about what these tests are intended to check? Will do before landing the patch. > -> I prefer to use the monospace font instead of Ahem, usually font: 16px/1.25 monospace, but it is just a preference. I've noticed differences between platforms. It's important to really have the same text in each region as the ref test. > -> why are you using <span style="line-height: 100px;">XXXXXX</span> in *-expected.html files? Do you need them in all the boxes? To push the bottom border further down and then clip it with overflow: hidden. This way the ref test divs look like they are fragmented.
Created attachment 207331 [details] Patch
Comment on attachment 207331 [details] Patch Clearing flags on attachment: 207331 Committed r153057: <http://trac.webkit.org/changeset/153057>