I think it's good for users if users mistake to write invalid mimetypes, WebKit finds plugin through file extensions. Now, WebKit finds plugin through file extensions when a mimetype is only null. How do you think about that?
Created attachment 206724 [details] patch change the logic.
Comment on attachment 206724 [details] patch Attachment 206724 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1089099 New failing tests: fullscreen/full-screen-iframe-with-max-width-height.html
Created attachment 206728 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.3
I don't understand why rayout test fail... I just changed findplugin code a little...
Comment on attachment 206724 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=206724&action=review > Source/WebKit2/ChangeLog:3 > + Support findPlugin through file extentions when a mimetype isn't null. Needs [WK2] prefix. I will retitle the bug. > Source/WebKit2/ChangeLog:8 > + To find plugin through file extentions even if mimetype isn't null. It'd be good to elaborate a bit here. Why is this change needed?
It’s generally not a good idea to disregard an explicitly provided MIME type.
(In reply to comment #6) > It’s generally not a good idea to disregard an explicitly provided MIME type. I agree, but I don't feel too strongly about it. However, if we don't have any evidence of real world web sites that are fixed by this change I don't think we should make it.