Bug 118699 – [EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_text_checker.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Donggwan Kim]

Many mouseClick methods are used in test_ewk2_text_checker.cpp.
But it is difficult to understand what they mean.
So i would like to replace those with more meaningful method for readability.

[Donggwan Kim]

Created attachment 206725 [details]
Patch

[Chris Dumez]

Comment on attachment 206725 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206725&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:74
> +    void showContextMenuWithFirstLineText()

How about introducing enums:
enum Line { FirstLine, SecondLine }
enum Button { SelectAllWithSpellcheckButton, SelectAllWithoutSpellcheckButton, SelectSubWordWithSpellcheckButton }

and rename the methods to:
clickButton(Button button);
showContextMenu(Line line);
selectFirstWord(Line line);

[Donggwan Kim]

It sounds good to me. 
I will modify and upload the patch again as you guided.

[Donggwan Kim]

Created attachment 206729 [details]
Patch

[Donggwan Kim]

It sounds good to me. 
I will modify and upload the patch again as you guided.

[Chris Dumez]

Comment on attachment 206729 [details]
Patch

Ok, r=me.

[WebKit Commit Bot]

Comment on attachment 206729 [details]
Patch

Clearing flags on attachment: 206729

Committed r152708: <http://trac.webkit.org/changeset/152708>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.