Bug 118699 - [EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_text_checker.cpp
Summary: [EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_text_c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 118698
  Show dependency tree / graph
 
Reported: 2013-07-15 18:26 PDT by Donggwan Kim
Modified: 2013-07-16 00:35 PDT (History)
4 users (show)

See Also:

Attachments
Patch (17.90 KB, patch)
2013-07-15 23:01 PDT, Donggwan Kim 		no flags Details | Formatted Diff | Diff
Patch (18.20 KB, patch)
2013-07-15 23:44 PDT, Donggwan Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Donggwan Kim 2013-07-15 18:26:21 PDT 
Many mouseClick methods are used in test_ewk2_text_checker.cpp.
But it is difficult to understand what they mean.
So i would like to replace those with more meaningful method for readability.
Comment 1 Donggwan Kim 2013-07-15 23:01:31 PDT 
Created attachment 206725 [details]
Patch
Comment 2 Chris Dumez 2013-07-15 23:23:03 PDT 
Comment on attachment 206725 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206725&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:74
> +    void showContextMenuWithFirstLineText()

How about introducing enums:
enum Line { FirstLine, SecondLine }
enum Button { SelectAllWithSpellcheckButton, SelectAllWithoutSpellcheckButton, SelectSubWordWithSpellcheckButton }

and rename the methods to:
clickButton(Button button);
showContextMenu(Line line);
selectFirstWord(Line line);
Comment 3 Donggwan Kim 2013-07-15 23:25:35 PDT 
It sounds good to me. 
I will modify and upload the patch again as you guided.
Comment 4 Donggwan Kim 2013-07-15 23:44:34 PDT 
Created attachment 206729 [details]
Patch
Comment 5 Donggwan Kim 2013-07-15 23:44:57 PDT 
It sounds good to me. 
I will modify and upload the patch again as you guided.
Comment 6 Chris Dumez 2013-07-15 23:56:58 PDT 
Comment on attachment 206729 [details]
Patch

Ok, r=me.
Comment 7 WebKit Commit Bot 2013-07-16 00:34:59 PDT 
Comment on attachment 206729 [details]
Patch

Clearing flags on attachment: 206729

Committed r152708: <http://trac.webkit.org/changeset/152708>
Comment 8 WebKit Commit Bot 2013-07-16 00:35:01 PDT 
All reviewed patches have been landed.  Closing bug.