Bug 118679 - NetworkStorageSession::createDefaultSession is only implemented by Soup
Summary: NetworkStorageSession::createDefaultSession is only implemented by Soup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kwang Yul Seo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-15 10:36 PDT by Alexey Proskuryakov
Modified: 2013-07-15 16:40 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.75 KB, patch)
2013-07-15 16:19 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-07-15 10:36:08 PDT 
NetworkStorageSession::createDefaultSession() is declared a cross-platform function, but it is only implemented or used by Soup.

Can you please fix this? I suspect that it is just incorrect, as there is only one default session, which is returned by defaultStorageSession().
Comment 1 Kwang Yul Seo 2013-07-15 15:30:17 PDT 
(In reply to comment #0)
> NetworkStorageSession::createDefaultSession() is declared a cross-platform function, but it is only implemented or used by Soup.
> 
> Can you please fix this? I suspect that it is just incorrect, as there is only one default session, which is returned by defaultStorageSession().

Currently, only _ewk_view_priv_new in WebKit/efl/ewk/ewk_view.cpp uses this method. This is incorrect because we already have defaultStorageSession().

I will fix it.
Comment 2 Kwang Yul Seo 2013-07-15 16:19:56 PDT 
Created attachment 206699 [details]
Patch
Comment 3 Kwang Yul Seo 2013-07-15 16:40:45 PDT 
Comment on attachment 206699 [details]
Patch

Clearing flags on attachment: 206699

Committed r152672: <http://trac.webkit.org/changeset/152672>
Comment 4 Kwang Yul Seo 2013-07-15 16:40:51 PDT 
All reviewed patches have been landed.  Closing bug.