Bug 118675 - [ATK] Leak: Leaks in testatk.c
Summary: [ATK] Leak: Leaks in testatk.c
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brian Holt
URL:
Keywords:
Depends on:
Blocks: 116317
  Show dependency tree / graph
 
Reported: 2013-07-15 08:40 PDT by Brian Holt
Modified: 2013-09-02 07:39 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.46 KB, patch)
2013-07-15 09:27 PDT, Brian Holt 		no flags Details | Formatted Diff | Diff
Rebased to master (9.70 KB, patch)
2013-09-02 02:44 PDT, Brian Holt 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Holt 2013-07-15 08:40:32 PDT 
Fix leaks in the testatk.c unit test.
Comment 1 Brian Holt 2013-07-15 09:27:01 PDT 
Created attachment 206668 [details]
Patch
Comment 2 Mario Sanchez Prada 2013-07-15 09:39:05 PDT 
Comment on attachment 206668 [details]
Patch

Thanks for the patch (and the general cleanup). Assuming you are not double-unreffing/freeing anything (which I think you are not), the patch looks good to me
Comment 3 Brian Holt 2013-07-16 13:22:08 PDT 
(In reply to comment #2)
> (From update of attachment 206668 [details])
> Thanks for the patch (and the general cleanup). Assuming you are not double-unreffing/freeing anything (which I think you are not), the patch looks good to me

Having gone over the patch quite thoroughly I am satisfied that there is no double free'ing and that the logic isn't changed.
Comment 4 Brian Holt 2013-09-02 02:44:18 PDT 
Created attachment 210273 [details]
Rebased to master
Comment 5 Mario Sanchez Prada 2013-09-02 07:16:46 PDT 
Comment on attachment 210273 [details]
Rebased to master

Thanks for rebasing the patch. It still looks good to me now and, on top of that, it also seems like a good one to give my first r+ to as a newborn reviewer ;)

PS: I'm also setting the cq+. Hope you don't mind me doing it.
Comment 6 WebKit Commit Bot 2013-09-02 07:39:53 PDT 
Comment on attachment 210273 [details]
Rebased to master

Clearing flags on attachment: 210273

Committed r154953: <http://trac.webkit.org/changeset/154953>
Comment 7 WebKit Commit Bot 2013-09-02 07:39:56 PDT 
All reviewed patches have been landed.  Closing bug.