Bug 118672 - Introduce toHTMLIFrameElement
Summary: Introduce toHTMLIFrameElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kangil Han
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-15 05:58 PDT by Kangil Han
Modified: 2013-07-15 22:00 PDT (History)
9 users (show)

See Also:


Attachments
Patch (8.92 KB, patch)
2013-07-15 06:03 PDT, Kangil Han
no flags Details | Formatted Diff | Diff
Patch (8.88 KB, patch)
2013-07-15 17:51 PDT, Kangil Han
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kangil Han 2013-07-15 05:58:14 PDT
Introduce toHTMLIFrameElement
Comment 1 Kangil Han 2013-07-15 06:03:50 PDT
Created attachment 206659 [details]
Patch
Comment 2 Ryosuke Niwa 2013-07-15 11:16:35 PDT
Comment on attachment 206659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206659&action=review

> Source/WebCore/dom/Document.cpp:5640
> +    return toHTMLIFrameElement(this->ownerElement());

It seems like we don't need "this->" anymore.
Comment 3 Kangil Han 2013-07-15 17:51:16 PDT
Created attachment 206708 [details]
Patch
Comment 4 Kangil Han 2013-07-15 21:19:10 PDT
(In reply to comment #2)
> (From update of attachment 206659 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206659&action=review
> 
> > Source/WebCore/dom/Document.cpp:5640
> > +    return toHTMLIFrameElement(this->ownerElement());
> 
> It seems like we don't need "this->" anymore.

Done, thx Ryosuke! :)
Comment 5 WebKit Commit Bot 2013-07-15 22:00:29 PDT
Comment on attachment 206708 [details]
Patch

Clearing flags on attachment: 206708

Committed r152704: <http://trac.webkit.org/changeset/152704>
Comment 6 WebKit Commit Bot 2013-07-15 22:00:32 PDT
All reviewed patches have been landed.  Closing bug.