Bug 118653 – Add toSVGFilterElement() and use it

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Gyuyoung Kim]

We can use toSVGFilterElement() instead of using static_cast<..> to improve readability. Beside blink also uses it.

[Gyuyoung Kim]

Created attachment 206628 [details]
Patch

[Build Bot]

Comment on attachment 206628 [details]
Patch

Attachment 206628 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1063594

New failing tests:
fullscreen/full-screen-iframe-with-max-width-height.html

[Build Bot]

Created attachment 206629 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Gyuyoung Kim]

Created attachment 206631 [details]
Patch for landing

[Gyuyoung Kim]

(In reply to comment #2)
> (From update of attachment 206628 [details])
> Attachment 206628 [details] did not pass mac-ews (mac):
> Output: http://webkit-queues.appspot.com/results/1063594
> 
> New failing tests:
> fullscreen/full-screen-iframe-with-max-width-height.html

Looks unrelated to this patch.

[WebKit Commit Bot]

Comment on attachment 206631 [details]
Patch for landing

Clearing flags on attachment: 206631

Committed r152615: <http://trac.webkit.org/changeset/152615>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

Comment on attachment 206631 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=206631&action=review

> Source/WebCore/svg/SVGFilterElement.h:80
> +    ASSERT_WITH_SECURITY_IMPLICATION(!node || node->hasTagName(SVGNames::filterTag));

It broke the debug builds. Could you fix it please?
(Otherwise it would be great if you could try a debug build locally 
next time if you add an assertion, because assertions are debug only.)

[Ryosuke Niwa]

Fixed builds in http://trac.webkit.org/changeset/152619.

[Gyuyoung Kim]

(In reply to comment #8)
> (From update of attachment 206631 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206631&action=review
> 
> > Source/WebCore/svg/SVGFilterElement.h:80
> > +    ASSERT_WITH_SECURITY_IMPLICATION(!node || node->hasTagName(SVGNames::filterTag));
> 
> It broke the debug builds. Could you fix it please?
> (Otherwise it would be great if you could try a debug build locally 
> next time if you add an assertion, because assertions are debug only.)

I too often forget to check if debug build is fine. :( Sorry about that. I will check debug build in next time.

[Gyuyoung Kim]

(In reply to comment #8)
> (From update of attachment 206631 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206631&action=review
> 
> > Source/WebCore/svg/SVGFilterElement.h:80
> > +    ASSERT_WITH_SECURITY_IMPLICATION(!node || node->hasTagName(SVGNames::filterTag));
> 
> It broke the debug builds. Could you fix it please?
> (Otherwise it would be great if you could try a debug build locally 
> next time if you add an assertion, because assertions are debug only.)

I too often forget to check if debug build is fine. :( Sorry about that. I will check debug build in next time.