RESOLVED WONTFIX 118626
Introduce non-virtual Node::isFocusable and virtual rendererIsFocusable 
https://bugs.webkit.org/show_bug.cgi?id=118626
Summary Introduce non-virtual Node::isFocusable and virtual rendererIsFocusable
Ryosuke Niwa
Reported 2013-07-12 16:38:04 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/94f9474455c2f83c606293c2608c0db8d266ada6 Before this patch, there were two virtual methods Node::isFocusable and Node::supportsFocus. This patch renames isFocusable to rendererIsFocusable, and introduces a new non-virtual method isFocusable which calls supportsFocus and rendererIsFocusable. The motivation is to clarify the purposes of the two virtual methods and provide a central place for universal checks on focusability, such as whether the node is in the document and non-inert (to be added later). This patch is just a refactoring and should not change behavior. Also see https://chromium.googlesource.com/chromium/blink/+/a21759964af400159c6ef86c57a7b677202bbffa
Attachments
Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-08-12 20:46:08 PDT
There has been a number of patches dependent on this one including https://chromium.googlesource.com/chromium/blink/+/a85c013184cf9e663f8bb74abbecfefc924807c0%5E%21/#F0
Ryosuke Niwa
Comment 2 2022-08-21 18:52:04 PDT
We're not gonna do merge this at this point.
Note You need to log in before you can comment on or make changes to this bug.