RESOLVED WONTFIX 118619
Simplify LocalStorage and SessionStorage to reduce the size of PageGroup 
https://bugs.webkit.org/show_bug.cgi?id=118619
Summary Simplify LocalStorage and SessionStorage to reduce the size of PageGroup
Ryosuke Niwa
Reported 2013-07-12 14:52:30 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/2b5b2e5c7a3c26e7f0b17c48137d17f140528b0d Quite a few cleanups in one: - Expose only a StorageArea factory for LocalStorage to core. - With the above, only use StorageNamespace instances to manage SessionStorage. - Eliminate all the unused methods of StorageNamepace from Blink, especially copy() (the last user was DumpRenderTree, which is now gone). Copying session storage on window creation is handled on the Chromium side. - Use OwnPtrs instead of RefPtrs for managing the lifetime of StorageNamespace and StorageArea. This change also has the advantage of further-reducing the size of PageGroup.
Attachments
Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-07-12 16:35:11 PDT
I don’t know if this patch would even apply cleanly - I’ve done a lot of cleanup in the storage code to make it better.
Ryosuke Niwa
Comment 2 2013-07-13 02:41:47 PDT
Should we close this as WONTFIX then?
Sam Weinig
Comment 3 2013-07-13 17:53:43 PDT
Yes.
Note You need to log in before you can comment on or make changes to this bug.