Bug 118605 - Web Inspector: update CodeMirror to 3.14.1
Summary: Web Inspector: update CodeMirror to 3.14.1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on: 118658
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-12 07:57 PDT by Timothy Hatcher
Modified: 2013-08-23 13:31 PDT (History)
6 users (show)

See Also:


Attachments
Patch (231.61 KB, patch)
2013-07-12 07:59 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Patch (237.74 KB, patch)
2013-07-15 15:35 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2013-07-12 07:57:18 PDT
There are a few fixes in 7f560afa1c that fix regressions from CodeMirror 3.14 that we should pick up and live on.
Comment 1 Radar WebKit Bug Importer 2013-07-12 07:57:37 PDT
<rdar://problem/14427280>
Comment 2 Timothy Hatcher 2013-07-12 07:59:39 PDT
Created attachment 206548 [details]
Patch
Comment 3 Sam Weinig 2013-07-12 11:09:26 PDT
Comment on attachment 206548 [details]
Patch

rs=me
Comment 4 WebKit Commit Bot 2013-07-12 11:32:24 PDT
Comment on attachment 206548 [details]
Patch

Clearing flags on attachment: 206548

Committed r152598: <http://trac.webkit.org/changeset/152598>
Comment 5 WebKit Commit Bot 2013-07-12 11:32:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Tim Horton 2013-07-14 23:37:00 PDT
This totally broke the inspector for me.

CodeMirror.js:701: JS ERROR: SyntaxError: Expected token '}'

I'm going to roll it out.
Comment 7 WebKit Commit Bot 2013-07-14 23:38:19 PDT
Re-opened since this is blocked by bug 118658
Comment 8 Timothy Hatcher 2013-07-15 08:00:54 PDT
This happened because the JS minifier caused an error in CodeMirror. We fixed this before, but I forgot to upstream that fix to CodeMirror.
Comment 9 Timothy Hatcher 2013-07-15 15:35:46 PDT
Created attachment 206694 [details]
Patch
Comment 10 Joseph Pecoraro 2013-07-15 15:38:05 PDT
Comment on attachment 206694 [details]
Patch

r=me
Comment 11 WebKit Commit Bot 2013-07-15 16:30:36 PDT
Comment on attachment 206694 [details]
Patch

Clearing flags on attachment: 206694

Committed r152669: <http://trac.webkit.org/changeset/152669>
Comment 12 WebKit Commit Bot 2013-07-15 16:30:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 13 Joseph Pecoraro 2013-08-23 13:31:29 PDT
Oops, I did this again…