Bug 118603 – [jhbuild] Avoid restarting from scratch failed initial checkouts

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Emanuele Aina]

Created attachment 206546 [details]
Patch

If the initial checkout is interrupted midway (eg. because the internet                                                 
connection went down) config files do not get generated and that causes                                                 
the next checkout to start from scratch (the missing files cause the                                                    
script to delete the build root and the downloaded sources).                                                            
                                                                                                                        
By generating the files before invoking jhbuild, subsequent runs are able                                               
to start where the previous run left.

[WebKit Commit Bot]

Attachment 206546 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/update-webkit-libs-jhbuild']" exit_code: 1
Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Martin Robinson]

Comment on attachment 206546 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206546&action=review

> Tools/ChangeLog:3
> +        [jhbuild] Avoid restarting from scratch failed initial checkouts

Looks good to me other than the missing bug URL here.

[Emanuele Aina]

(In reply to comment #2)
> Looks good to me other than the missing bug URL here.

Yup, I used `webkit-patch create-bug` for the upload assuming that it was going to automagically take care somewhat of this as `git bz` does, but does not seems to be the case. Knowing this I wonder about the usefulness `webkit-patch create-bug`...

However, I'll upload a fixed patch in a minute. Thanks for the review!

[Emanuele Aina]

Created attachment 206549 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 206549 [details]
Patch

Rejecting attachment 206549 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 206549, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/1064127

[Emanuele Aina]

(In reply to comment #5)
> /Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Martin, sorry for the newbieness, should I have added you to the Changelog entry in the "Reviewed by" line?
Should I reupload the patch after adding "Reviewed by Martin Robinson."?

[Martin Robinson]

(In reply to comment #6)
> (In reply to comment #5)
> > /Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
> 
> Martin, sorry for the newbieness, should I have added you to the Changelog entry in the "Reviewed by" line?
> Should I reupload the patch after adding "Reviewed by Martin Robinson."?

No worries. You can either leave the "Reviewed by OOPS" line or add "Reviewed by Martin Robinson." The commit-queue knows how to fill out the reviewer field (but not other OOPS types).

[Emanuele Aina]

(In reply to comment #7)
> > Martin, sorry for the newbieness, should I have added you to the Changelog entry in the "Reviewed by" line?
> > Should I reupload the patch after adding "Reviewed by Martin Robinson."?
> 
> No worries. You can either leave the "Reviewed by OOPS" line or add "Reviewed by Martin Robinson." The commit-queue knows how to fill out the reviewer field (but not other OOPS types).

Oh, I see, I removed the OOPS not knowing how the magic was supposed to work. :/
I'll upload the patch with "Reviewed by Martin Robinson." in a moment.

Thanks!

[Emanuele Aina]

Created attachment 206555 [details]
Patch

Added missing 'Reviewed by' line to the ChangeLog

[WebKit Commit Bot]

Comment on attachment 206555 [details]
Patch

Clearing flags on attachment: 206555

Committed r152605: <http://trac.webkit.org/changeset/152605>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.