Bug 118592 – check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Brian Holt]

$ Tools/Scripts/check-webkit-style Tools/Scripts/webkitpy/port/common.py
Tools/Scripts/webkitpy/port/common.py:129:  [RunSubprocess] Instance of 'Popen' has no 'pid' member (but some types could not be inferred)  [pylint/E1103] [5]
Tools/Scripts/webkitpy/port/common.py:132:  [RunSubprocess] Instance of 'Popen' has no 'pid' member (but some types could not be inferred)  [pylint/E1103] [5]
Tools/Scripts/webkitpy/port/common.py:133:  [RunSubprocess] Instance of 'Popen' has no 'pid' member (but some types could not be inferred)  [pylint/E1103] [5]

This is clearly an error because Popen does have a pid member: http://docs.python.org/2/library/subprocess.html
Popen.pid
    The process ID of the child process.
    Note that if you set the shell argument to True, this is the process ID of the spawned shell.

As recommended by dpranke in https://bugs.webkit.org/show_bug.cgi?id=101285#c16, this bug is to add the "Instance of 'Popen' has no 'pid' member" to the list of pylint false positives.

[Brian Holt]

Created attachment 206520 [details]
Patch

[Build Bot]

Comment on attachment 206520 [details]
Patch

Attachment 206520 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1063099

New failing tests:
fullscreen/full-screen-iframe-with-max-width-height.html

[Build Bot]

Created attachment 206535 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[Brian Holt]

(In reply to comment #3)
> Created an attachment (id=206535) [details]
> Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
> Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

The failing test is clearly unrelated to the patch.

[Martin Robinson]

Comment on attachment 206520 [details]
Patch

This could probably use a new test.

[Brian Holt]

Created attachment 206552 [details]
Patch with unit test

[WebKit Commit Bot]

Attachment 206552 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/style/checkers/python.py', u'Tools/Scripts/webkitpy/style/checkers/python_unittest.py', u'Tools/Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py']" exit_code: 1
Tools/Scripts/webkitpy/style/checkers/python_unittest.py:77:  [PythonCheckerTest.test_pylint_false_positives] Undefined variable '_mock_handle_style_error'  [pylint/E0602] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 206552 [details]
Patch with unit test

Clearing flags on attachment: 206552

Committed r152599: <http://trac.webkit.org/changeset/152599>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Brian Holt]

Created attachment 206559 [details]
Updated patch with unit test

[WebKit Commit Bot]

Re-opened since this is blocked by bug 118612

[Brian Holt]

Created attachment 206562 [details]
Updated patch with unit test

Uploading again so that the bots can test.

[Brian Holt]

Comment on attachment 206562 [details]
Updated patch with unit test

This patch is not applying cleanly, so I'm removing the review request and will upload a new version on Monday.

[Brian Holt]

Created attachment 206649 [details]
Patch

[Brian Holt]

Created attachment 206660 [details]
Final patch

All webkitpy tests now pass

[Brian Holt]

Comment on attachment 206660 [details]
Final patch

Whoops! Just noticed that the ChangeLog is not correct.  My apologies for the churn.

[Brian Holt]

Created attachment 206661 [details]
Final patch

Corrected ChangeLog, aplogoes for the churn.

[WebKit Commit Bot]

Comment on attachment 206661 [details]
Final patch

Clearing flags on attachment: 206661

Committed r152639: <http://trac.webkit.org/changeset/152639>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.