Bug 118572 - Plugins that don't support snapshotting should not all autostart.
Summary: Plugins that don't support snapshotting should not all autostart.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Roger Fong
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-07-11 11:09 PDT by Roger Fong
Modified: 2013-07-11 17:01 PDT (History)
8 users (show)

See Also:

Attachments
Patch (10.58 KB, patch)
2013-07-11 11:12 PDT, Roger Fong 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2013-07-11 11:09:48 PDT 
Currently plugins that don't support snapshotting all autostart (quicktime, silverlight, etc). 
This should not be the case.
Comment 1 Roger Fong 2013-07-11 11:12:37 PDT 
Created attachment 206477 [details]
Patch
Comment 2 Dean Jackson 2013-07-11 16:22:19 PDT 
Comment on attachment 206477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206477&action=review

> Source/WebCore/html/HTMLPlugInImageElement.cpp:387
> +    argList.append(JSC::jsBoolean(!m_snapshotImage));

I think we should put a comment here to explain that this parameter determines if the overlay should be always visible, which we want when we don't have a good snapshot.
Comment 3 Roger Fong 2013-07-11 16:55:01 PDT 
<rdar://problem/14324391>
Comment 4 Roger Fong 2013-07-11 17:01:53 PDT 
Committed: http://trac.webkit.org/changeset/152580