Bug 118554 – Remove 'static' specifier from free inline functions in StringImpl.h

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Mikhail Pozdnyakov]

SSIA. The rational: at first 'static' does not bring any use here, secondly static free inline functions in headers is a bad practice in general as each instance of function defined as inline is treated as a separate function and each instance has its own copy of static locals and string literals.

[Mikhail Pozdnyakov]

Created attachment 206438 [details]
patch

[Anders Carlsson]

I’m not sure about this patch. Static does ensure that the function won’t be visible in other translation units, and that should speed up linking (I think).

On the other hand, if any of the functions don’t end up being inlined, it’d would mean that there are extra copies of the same functions around.

Did you do any measuring of the size of the WebCore library with/without this change? (With optimizations enabled)

[Mikhail Pozdnyakov]

(In reply to comment #2)
> I’m not sure about this patch. Static does ensure that the function won’t be visible in other translation units, and that should speed up linking (I think).
> 
> On the other hand, if any of the functions don’t end up being inlined, it’d would mean that there are extra copies of the same functions around.
> 
> Did you do any measuring of the size of the WebCore library with/without this change? (With optimizations enabled)

Tried efl release build, 'ls' says that size of libjavascriptcore_efl.so has slightly decreased from 6520696 to 6520688 after the patch is applied.

[Build Bot]

Comment on attachment 206438 [details]
patch

Attachment 206438 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/954951

New failing tests:
http/tests/security/cross-origin-plugin-private-browsing-toggled.html

[Build Bot]

Created attachment 206484 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[Mikhail Pozdnyakov]

(In reply to comment #4)
> (From update of attachment 206438 [details])
> Attachment 206438 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.appspot.com/results/954951
> 
> New failing tests:
> http/tests/security/cross-origin-plugin-private-browsing-toggled.html

Looks unrelated.

[WebKit Commit Bot]

Comment on attachment 206438 [details]
patch

Clearing flags on attachment: 206438

Committed r164175: <http://trac.webkit.org/changeset/164175>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.