Bug 118531 – [CSS Regions] In a region chain with auto-height regions, lines get their length based only on the first region

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Mihai Balan]

Created attachment 206392 [details]
Test-case

If a region chain has regions with height: auto and specified widths, line breaking will not take into consideration the width of the current region, but the width of the first region. This can lead to text overflowing a region (if narrower than the first region) or to regions unnecessarily tall and with unneeded whitespace (if wider than the first region).

[Andrei Bucur]

Created attachment 206463 [details]
Patch

[Alexandru Chiculita]

Comment on attachment 206463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206463&action=review

Looks good.

> Source/WebCore/rendering/RenderFlowThread.cpp:267
> +    ASSERT(computedValues.m_extent >= 0);

Looks like having no regions will hit this assert computedValues.m_extent >= 0

> Source/WebCore/rendering/RenderFlowThread.h:171
> +    static LayoutUnit maxFlowThreadSize() { return LayoutUnit::max() / 2; }

nit: I would not repeat the flowThread in the name and I think we should mention that it refers to the logicalHeight of the flow. What about maxLogicalHeight() ? Add a comment that it is used to estimate the size of the flow.

[Andrei Bucur]

Created attachment 206467 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 206467 [details]
Patch

Clearing flags on attachment: 206467

Committed r152572: <http://trac.webkit.org/changeset/152572>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.