Bug 11853 - REGRESSION (r17352): Whitespace in <title> is rendered
Summary: REGRESSION (r17352): Whitespace in <title> is rendered
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Nobody
URL:
Keywords: HasReduction, Regression
Depends on:
Blocks:
 
Reported: 2006-12-16 11:20 PST by Matt Lilek
Modified: 2007-01-18 19:52 PST (History)
2 users (show)

See Also:

Attachments
reduction (238 bytes, text/html)
2006-12-16 11:21 PST, Matt Lilek 		no flags Details
patch (4.00 KB, patch)
2007-01-16 16:13 PST, Sam Weinig 		mjs: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lilek 2006-12-16 11:20:53 PST 
Excessive whitespace in the <title> element is rendered on ToT but not Safari 2.0.4 (or any other browser).  Probably due to the loader refactoring?
Comment 1 Matt Lilek 2006-12-16 11:21:37 PST 
Created attachment 11884 [details]
reduction
Comment 2 mitz 2006-12-16 11:42:50 PST 
I think this is a result of <http://trac.webkit.org/projects/webkit/changeset/17352>, which promised to "[replace] stringByCollapsingNonPrintingCharacters with a c++ equivalent". I couldn't find the equivalent, nor when it is applied to the title.
Comment 3 Matt Lilek 2006-12-16 11:59:29 PST 
Bug11692 seems to have been caused by that change too.
Comment 4 Sam Weinig 2007-01-16 16:13:27 PST 
Created attachment 12496 [details]
patch

Patch modifies the method canonicalizedTitle() to collapse the internal whitespace.  This required removing an optimization in the function.  I added a test to the manuel tests as the DRT does not dump the title.
Comment 5 Maciej Stachowiak 2007-01-16 22:02:57 PST 
r=me

Might be worth enhancing layout tests to be able to dump title.
Comment 6 Mark Rowe (bdash) 2007-01-18 19:52:47 PST 
Landed in r18972.