Bug 118525 – Get rid of SVGPathSeg* special casing in the bindings generator

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

Have one header per SVGPathSeg* type so that we no longer need special casing in the bindings generator.

[Chris Dumez]

Created attachment 206372 [details]
WIP Patch

[Chris Dumez]

Created attachment 206374 [details]
Patch

[Mikhail Pozdnyakov]

Comment on attachment 206374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206374&action=review

> Source/WebCore/svg/SVGPathSegArcRel.h:44
> +    virtual String pathSegTypeAsLetter() const { return "a"; }

It looks that ASCIILiteral would be nice to have here.

[Chris Dumez]

(In reply to comment #3)
> (From update of attachment 206374 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206374&action=review
> 
> > Source/WebCore/svg/SVGPathSegArcRel.h:44
> > +    virtual String pathSegTypeAsLetter() const { return "a"; }
> 
> It looks that ASCIILiteral would be nice to have here.

I am not sure we want to do such changes in this patch. This patch is really about splitting the code so that we can get rid of special cases in the bindings generator.

I don't mind making such changes if people think it is a good idea though.

[Chris Dumez]

@haraken: Is this something you could review? The important changes are to the bindings generator, the SVG code is merely split into separate files without any change.

[Kentaro Hara]

Comment on attachment 206374 [details]
Patch

The code generator change looks good. Other changes are just moving code. Looks OK.

[Chris Dumez]

Created attachment 206435 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 206435 [details]
Patch for landing

Clearing flags on attachment: 206435

Committed r152565: <http://trac.webkit.org/changeset/152565>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.