Bug 118521 - [EFL] Add ewk_view_device_pixel_ratio_set
Summary: [EFL] Add ewk_view_device_pixel_ratio_set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-09 19:04 PDT by Ryuan Choi
Modified: 2013-07-09 20:34 PDT (History)
7 users (show)

See Also:

Attachments
Patch (13.86 KB, patch)
2013-07-09 19:36 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2013-07-09 19:04:15 PDT 
Now, ewebkit and ewebkit2 have different approach about getting device pixel ratio.
ewebkit depends on deprecatedTargetDPI and ecore_x_dpi_get but ewebkit2 use Page::deviceScaleFactor.
Comment 1 Ryuan Choi 2013-07-09 19:36:17 PDT 
Created attachment 206361 [details]
Patch
Comment 2 Gyuyoung Kim 2013-07-09 20:06:25 PDT 
Comment on attachment 206361 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206361&action=review

Looks OK.

> Tools/EWebLauncher/main.c:153
> +    double device_pixel_ratio;

Isn't float more clear ?
Comment 3 Ryuan Choi 2013-07-09 20:33:55 PDT 
Committed r152523: <http://trac.webkit.org/changeset/152523>
Comment 4 Ryuan Choi 2013-07-09 20:34:36 PDT 
(In reply to comment #2)
> (From update of attachment 206361 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206361&action=review
> 
> Looks OK.
> 
> > Tools/EWebLauncher/main.c:153
> > +    double device_pixel_ratio;
> 
> Isn't float more clear ?

Landed after fixed like you mentioned.
Thank you