Bug 118517 - AuthenticationMac.mm does not handle NSURLAuthenticationMethodNegotiate
Summary: AuthenticationMac.mm does not handle NSURLAuthenticationMethodNegotiate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Unspecified
: P2 Major
Assignee: Jeff Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-07-09 12:32 PDT by Jeff Miller
Modified: 2013-07-09 13:52 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.72 KB, patch)
2013-07-09 12:37 PDT, Jeff Miller
beidson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Miller 2013-07-09 12:32:46 PDT
When NSURLAuthenticationMethodNegotiate is returned from -[NSURLProtectionSpace authenticationMethod], we need to map it to ProtectionSpaceAuthenticationSchemeNegotiate.
Comment 1 Jeff Miller 2013-07-09 12:33:46 PDT
<rdar://problem/14391944>
Comment 2 Jeff Miller 2013-07-09 12:37:27 PDT
Created attachment 206347 [details]
Patch
Comment 3 Jeff Miller 2013-07-09 13:20:58 PDT
Committed http://trac.webkit.org/changeset/152513.
Comment 4 Alexey Proskuryakov 2013-07-09 13:35:56 PDT
Comment on attachment 206347 [details]
Patch

This patch only added support for the scheme in one direction. Shouldn't the mac() function also be updated?
Comment 5 Jeff Miller 2013-07-09 13:49:57 PDT
(In reply to comment #4)
> (From update of attachment 206347 [details])
> This patch only added support for the scheme in one direction. Shouldn't the mac() function also be updated?

You're right, I'll file another bug about this.
Comment 6 Jeff Miller 2013-07-09 13:52:43 PDT
I filed bug 118518.