8 bytes memory leaks in WebProcessMainQt.cpp when proxy is initialized
Created attachment 206344 [details] Patch
Attachment 206344 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/qt/WebProcessMainQt.cpp']" exit_code: 1 Source/WebKit2/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 206345 [details] Patch
Comment on attachment 206345 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206345&action=review > Source/WebKit2/WebProcess/qt/WebProcessMainQt.cpp:140 > + delete proxyFactory; You might want to use OwnPtr and QNetworkProxyFactory::setApplicationProxyFactory(proxyFactory.leakPtr()); to avoid manual memory handling.
Created attachment 206346 [details] Patch
Comment on attachment 206346 [details] Patch Looks good, r=me.
Thanks (In reply to comment #6) > (From update of attachment 206346 [details]) > Looks good, r=me.
What else can I do to make it landing? Is there anyone to help me about it?
Comment on attachment 206346 [details] Patch Though I'm not a QT port developer, this patch looks good.
(In reply to comment #8) > What else can I do to make it landing? Is there anyone to help me about it? Do not change bug status with "Resolved Fixed" manually. commit bot will change the status after landing. See also https://bugs.webkit.org/page.cgi?id=fields.html#status
Comment on attachment 206346 [details] Patch Clearing flags on attachment: 206346 Committed r156449: <http://trac.webkit.org/changeset/156449>
All reviewed patches have been landed. Closing bug.