Bug 118509 – [GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Pena]

[GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents

[Simon Pena]

Created attachment 206327 [details]
Patch

[Martin Robinson]

Comment on attachment 206327 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206327&action=review

> Tools/ChangeLog:14
> +        fast/events/mousedown-inside-dragstart-should-not-cause-crash.html no longer
> +        crashes after this fix is added.

This patch isn't removing it from the TestExpectations file though?

[Simon Pena]

(In reply to comment #2)
> This patch isn't removing it from the TestExpectations file though?

No, it isn't. The GTK-WK2 buildbot is a bit red these days, and this test has been failing probably forever (the flakiness dashboard doesn't have any records of it passing).

I am (slowly) trying to improve the bots situation these days, maybe I should have started skipping them first, and then go on with fixes?

[Simon Pena]

(In reply to comment #3)
> (In reply to comment #2)
> > This patch isn't removing it from the TestExpectations file though?
> 
> No, it isn't. The GTK-WK2 buildbot is a bit red these days, and this test has been failing probably forever (the flakiness dashboard doesn't have any records of it passing).

(The test wasn't skipped on GTK-WK1, it worked fine there)

[Martin Robinson]

Comment on attachment 206327 [details]
Patch

It's fine to just fix it now. Thanks!

[WebKit Commit Bot]

Comment on attachment 206327 [details]
Patch

Clearing flags on attachment: 206327

Committed r152530: <http://trac.webkit.org/changeset/152530>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.