Bug 118496 - Use toSVGFontElement() instead of static_cast<SVGFontElement*>
Summary: Use toSVGFontElement() instead of static_cast<SVGFontElement*>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-07-09 01:46 PDT by Gyuyoung Kim
Modified: 2013-07-09 04:32 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.47 KB, patch)
2013-07-09 01:51 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-07-09 01:46:02 PDT 
As a step to change static_cast with toXXX, static_cast<SVGFontElement*> can be changed with toSVGFontElement(). Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=153761
Comment 1 Gyuyoung Kim 2013-07-09 01:51:10 PDT 
Created attachment 206300 [details]
Patch
Comment 2 Andreas Kling 2013-07-09 04:09:14 PDT 
Comment on attachment 206300 [details]
Patch

r=me.

It would be nice to have an isSVGFontElement(const Node*) instead of checking hasTagName().
Comment 3 Gyuyoung Kim 2013-07-09 04:10:36 PDT 
(In reply to comment #2)
> (From update of attachment 206300 [details])
> r=me.
> 
> It would be nice to have an isSVGFontElement(const Node*) instead of checking hasTagName().

Ok, no problem. I will file a bug for it.
Comment 4 WebKit Commit Bot 2013-07-09 04:32:07 PDT 
Comment on attachment 206300 [details]
Patch

Clearing flags on attachment: 206300

Committed r152491: <http://trac.webkit.org/changeset/152491>
Comment 5 WebKit Commit Bot 2013-07-09 04:32:10 PDT 
All reviewed patches have been landed.  Closing bug.