Bug 118487 - Web Inspector: "Always enable" profiling does not work
Summary: Web Inspector: "Always enable" profiling does not work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: arno.
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-07-08 15:25 PDT by arno.
Modified: 2013-07-10 13:34 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2013-07-08 15:37 PDT, arno. 		no flags Details | Formatted Diff | Diff
same patch without the OOPS (1.55 KB, patch)
2013-07-10 10:37 PDT, arno. 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description arno. 2013-07-08 15:25:39 PDT 
Hi,
even when choosing "Always enable" in the profile panel, the panel enabler always shows up afterwards.
Comment 1 Radar WebKit Bug Importer 2013-07-08 15:26:07 PDT 
<rdar://problem/14381439>
Comment 2 arno. 2013-07-08 15:37:50 PDT 
Created attachment 206274 [details]
Patch
Comment 3 WebKit Commit Bot 2013-07-08 19:25:51 PDT 
Comment on attachment 206274 [details]
Patch

Rejecting attachment 206274 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 206274, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/1023510
Comment 4 arno. 2013-07-10 10:37:36 PDT 
Created attachment 206396 [details]
same patch without the OOPS
Comment 5 WebKit Commit Bot 2013-07-10 13:32:36 PDT 
Comment on attachment 206396 [details]
same patch without the OOPS

Clearing flags on attachment: 206396

Committed r152542: <http://trac.webkit.org/changeset/152542>
Comment 6 WebKit Commit Bot 2013-07-10 13:32:38 PDT 
All reviewed patches have been landed.  Closing bug.