RESOLVED FIXED 118478
Workaround for x86 optimizer bug in MSVC 2012. 
https://bugs.webkit.org/show_bug.cgi?id=118478
Summary Workaround for x86 optimizer bug in MSVC 2012.
Michael Brüning
Reported 2013-07-08 11:53:10 PDT
[Qt] Fix x86 optimizer bug in MSVC 2012.
Attachments
Patch (2.02 KB, patch)
2013-07-08 11:59 PDT, Michael Brüning 		no flags
DetailsFormatted DiffDiff
Patch (2.01 KB, patch)
2013-07-09 02:23 PDT, Michael Brüning 		benjamin: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (482.35 KB, application/zip)
2013-07-09 06:16 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Brüning
Comment 1 2013-07-08 11:59:36 PDT
Created attachment 206262 [details] Patch
Benjamin Poulain
Comment 2 2013-07-08 15:25:15 PDT
Comment on attachment 206262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206262&action=review > Source/WTF/wtf/text/StringImpl.cpp:488 > +#if PLATFORM(QT) && CPU(X86) && defined(_MSC_VER) && _MSC_VER >=1700 Why PLATFORM(QT)?
Michael Brüning
Comment 3 2013-07-09 02:19:04 PDT
(In reply to comment #2) > (From update of attachment 206262 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206262&action=review > > > Source/WTF/wtf/text/StringImpl.cpp:488 > > +#if PLATFORM(QT) && CPU(X86) && defined(_MSC_VER) && _MSC_VER >=1700 > > Why PLATFORM(QT)? Just because it was only reported with Qt so far - but you're right, it shouldn't hurt to put it in for other platforms using MSVC 2012 on x86 as well.
Michael Brüning
Comment 4 2013-07-09 02:23:31 PDT
Created attachment 206301 [details] Patch
Build Bot
Comment 5 2013-07-09 06:16:10 PDT
Comment on attachment 206301 [details] Patch Attachment 206301 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/911531 New failing tests: fullscreen/full-screen-iframe-with-max-width-height.html
Build Bot
Comment 6 2013-07-09 06:16:12 PDT
Created attachment 206313 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3
Michael Brüning
Comment 7 2013-07-09 07:32:37 PDT
(In reply to comment #6) > Created an attachment (id=206313) [details] > Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 > > The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. > Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3 Hm, I wonder how a change flagged for Visual Studio only would cause failures on the Mac port - is the tree on the ews in a bad state maybe?
Benjamin Poulain
Comment 8 2013-07-09 13:22:50 PDT
Comment on attachment 206301 [details] Patch You can double check but I think the bot is just sick. OS X is 64bits, and does not use MSVC :)
Michael Brüning
Comment 9 2013-07-10 01:37:15 PDT
Committed r152529: <http://trac.webkit.org/changeset/152529>
Note You need to log in before you can comment on or make changes to this bug.