Bug 118477 – [Mac] every enabled text track should be listed in the track menu

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

The logic that chooses text tracks for the track menu does not consider whether or not a track is visible, so it is possible for a track that is enabled and displaying cues to not be in the menu. This will cause a confusing user experience.

[Eric Carlson]

<rdar://problem/13832062>

[Eric Carlson]

Created attachment 206258 [details]
Proposed patch

[Build Bot]

Comment on attachment 206258 [details]
Proposed patch

Attachment 206258 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/987835

New failing tests:
media/video-controls-captions-trackmenu-includes-enabled-track.html

[Build Bot]

Created attachment 206263 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Build Bot]

Comment on attachment 206258 [details]
Proposed patch

Attachment 206258 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/864468

New failing tests:
media/video-controls-captions-trackmenu-includes-enabled-track.html

[Build Bot]

Created attachment 206286 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[Eric Carlson]

Created attachment 206332 [details]
Updated patch

[WebKit Commit Bot]

Comment on attachment 206332 [details]
Updated patch

Clearing flags on attachment: 206332

Committed r152547: <http://trac.webkit.org/changeset/152547>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.