Bug 118475 – @readonly and @aria-readonly="false" are not exposed correctly to accessibility

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[James Craig]

@readonly and @aria-readonly="false" are not exposed correctly to accessibility


https://dvcs.w3.org/hg/pfwg/raw-file/default/ARIA/1.0/tests/test-files/roles-properties-supported-inherited/roles-properties-supported-inherited-rowheader-aria-readonly-false.html

[Radar WebKit Bug Importer]

<rdar://problem/14376358>

[James Craig]

Created attachment 206271 [details]
patch

[WebKit Commit Bot]

Attachment 206271 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/accessibility/aria-readonly-expected.txt', u'LayoutTests/accessibility/aria-readonly.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp']" exit_code: 1
Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2713:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[James Craig]

Created attachment 206273 [details]
patch

[James Craig]

Created attachment 206291 [details]
patch, with comment typo corrections

m. no code changes since reviewed. just corrected comments in the test case previously meaning "required" state instead of "readonly."

[James Craig]

s/meaning/mentioning/

[WebKit Commit Bot]

Comment on attachment 206291 [details]
patch, with comment typo corrections

Rejecting attachment 206291 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 206291, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/892626

[Build Bot]

Comment on attachment 206291 [details]
patch, with comment typo corrections

Attachment 206291 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/909548

New failing tests:
fullscreen/full-screen-iframe-with-max-width-height.html

[Build Bot]

Created attachment 206308 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[James Craig]

Created attachment 206325 [details]
patch, adding the "Reviewed by NOBODY" string accidentally removed from the changelog

[WebKit Commit Bot]

Comment on attachment 206325 [details]
patch, adding the "Reviewed by NOBODY" string accidentally removed from the changelog 

Clearing flags on attachment: 206325

Committed r152522: <http://trac.webkit.org/changeset/152522>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.