Bug 118466 - Add Deque::removeLast
Summary: Add Deque::removeLast
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-08 05:22 PDT by Antti Koivisto
Modified: 2013-07-08 06:23 PDT (History)
3 users (show)

See Also:


Attachments
patch (2.35 KB, patch)
2013-07-08 05:25 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (2.35 KB, patch)
2013-07-08 05:28 PDT, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-07-08 05:22:07 PDT
Deque can remove both the first and the last element efficiently.
Comment 1 Antti Koivisto 2013-07-08 05:25:12 PDT
Created attachment 206231 [details]
patch
Comment 2 Antti Koivisto 2013-07-08 05:27:35 PDT
Comment on attachment 206231 [details]
patch

wrong patch
Comment 3 Antti Koivisto 2013-07-08 05:28:09 PDT
Created attachment 206233 [details]
patch
Comment 4 Andreas Kling 2013-07-08 05:36:03 PDT
Comment on attachment 206233 [details]
patch

r=me, though we should also improve remove() some day..

Also, this could use an API test.
Comment 5 Antti Koivisto 2013-07-08 06:23:48 PDT
http://trac.webkit.org/changeset/152449 (with API test)