Bug 118454 - [EFL] Enable CSS Image Orientation
Summary: [EFL] Enable CSS Image Orientation
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-07 16:59 PDT by Gyuyoung Kim
Modified: 2017-03-11 10:37 PST (History)
19 users (show)

See Also:


Attachments
WIP-1 (29.78 KB, patch)
2013-07-07 17:03 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
WIP-2 (47.81 KB, patch)
2013-07-08 07:36 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
WIP-3 (53.19 KB, patch)
2013-07-10 02:58 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
WIP-4 (52.62 KB, patch)
2013-07-12 01:53 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
WIP-5 pass efl and gtk ports (57.48 KB, patch)
2013-07-12 22:52 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
WIP-6 (EFL, GTK and Mac ports) (66.38 KB, patch)
2013-07-15 19:25 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (555.10 KB, application/zip)
2013-07-18 12:28 PDT, Build Bot
no flags Details
WIP-7 (57.94 KB, patch)
2013-07-19 03:09 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
WIP-8 (68.51 KB, patch)
2013-07-19 21:46 PDT, Gyuyoung Kim
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (545.98 KB, application/zip)
2013-07-22 03:58 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (312.49 KB, application/zip)
2013-07-31 16:40 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-07-07 16:59:53 PDT
SSIA. But, this bug will be used to keep WIP patches mainly.
Comment 1 Gyuyoung Kim 2013-07-07 17:03:37 PDT
Created attachment 206211 [details]
WIP-1
Comment 2 WebKit Commit Bot 2013-07-07 17:05:42 PDT
Attachment 206211 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/platform/DragImage.h', u'Source/WebCore/platform/efl/DragImageEfl.cpp', u'Source/WebCore/platform/graphics/BitmapImage.cpp', u'Source/WebCore/platform/graphics/BitmapImage.h', u'Source/WebCore/platform/graphics/GraphicsContext.cpp', u'Source/WebCore/platform/graphics/GraphicsContext.h', u'Source/WebCore/platform/graphics/ImageSource.cpp', u'Source/WebCore/platform/graphics/ImageSource.h', u'Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp', u'Source/WebCore/platform/mac/DragImageMac.mm', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/style/RenderStyle.cpp', u'Tools/Scripts/webkitperl/FeatureList.pm']" exit_code: 1
Source/WebCore/platform/DragImage.h:78:  The parameter name "orientation" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/loader/cache/CachedImage.cpp:259:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/loader/cache/CachedImage.cpp:260:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/loader/cache/CachedImage.cpp:263:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/loader/cache/CachedImage.cpp:264:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 5 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2013-07-07 17:10:50 PDT
Comment on attachment 206211 [details]
WIP-1

Attachment 206211 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1048215
Comment 4 Early Warning System Bot 2013-07-07 17:10:51 PDT
Comment on attachment 206211 [details]
WIP-1

Attachment 206211 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/976920
Comment 5 EFL EWS Bot 2013-07-07 17:19:31 PDT
Comment on attachment 206211 [details]
WIP-1

Attachment 206211 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/977702
Comment 6 kov's GTK+ EWS bot 2013-07-07 17:20:31 PDT
Comment on attachment 206211 [details]
WIP-1

Attachment 206211 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/975163
Comment 7 EFL EWS Bot 2013-07-07 17:22:03 PDT
Comment on attachment 206211 [details]
WIP-1

Attachment 206211 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1002250
Comment 8 Build Bot 2013-07-07 17:29:34 PDT
Comment on attachment 206211 [details]
WIP-1

Attachment 206211 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1031223
Comment 9 Build Bot 2013-07-07 17:43:02 PDT
Comment on attachment 206211 [details]
WIP-1

Attachment 206211 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/988169
Comment 10 Gyuyoung Kim 2013-07-08 07:36:57 PDT
Created attachment 206243 [details]
WIP-2
Comment 11 Gyuyoung Kim 2013-07-10 02:58:29 PDT
Created attachment 206376 [details]
WIP-3
Comment 12 Gyuyoung Kim 2013-07-12 01:53:17 PDT
Created attachment 206515 [details]
WIP-4
Comment 13 Gyuyoung Kim 2013-07-12 22:52:03 PDT
Created attachment 206593 [details]
WIP-5 pass efl and gtk ports
Comment 14 Gyuyoung Kim 2013-07-15 19:25:49 PDT
Created attachment 206718 [details]
WIP-6 (EFL, GTK and Mac ports)
Comment 15 Early Warning System Bot 2013-07-15 19:33:30 PDT
Comment on attachment 206718 [details]
WIP-6 (EFL, GTK and Mac ports)

Attachment 206718 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1080055
Comment 16 Early Warning System Bot 2013-07-15 19:35:17 PDT
Comment on attachment 206718 [details]
WIP-6 (EFL, GTK and Mac ports)

Attachment 206718 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1095002
Comment 17 Build Bot 2013-07-17 18:25:18 PDT
Comment on attachment 206718 [details]
WIP-6 (EFL, GTK and Mac ports)

Attachment 206718 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1103365
Comment 18 Build Bot 2013-07-18 12:28:28 PDT
Comment on attachment 206718 [details]
WIP-6 (EFL, GTK and Mac ports)

Attachment 206718 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1098655

New failing tests:
fast/canvas/pattern-with-transform.html
fast/canvas/canvas-pattern-modify.html
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html
webgl/conformance/extensions/oes-texture-float-with-canvas.html
canvas/philip/tests/2d.pattern.modify.canvas2.html
fast/canvas/webgl/tex-image-webgl.html
canvas/philip/tests/2d.pattern.paint.orientation.canvas.html
fast/canvas/canvas-pattern-behaviour.html
canvas/philip/tests/2d.pattern.modify.canvas1.html
http/tests/inspector/inspect-element.html
fast/canvas/webgl/texture-npot.html
canvas/philip/tests/initial.reset.pattern.html
webgl/conformance/textures/gl-teximage.html
webgl/conformance/context/premultiplyalpha-test.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551.html
editing/pasteboard/copy-image-with-alt-text.html
canvas/philip/tests/2d.pattern.basic.canvas.html
webgl/conformance/more/functions/texSubImage2DHTMLBadArgs.html
fast/canvas/webgl/tex-sub-image-2d-bad-args.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba4444.html
webgl/conformance/glsl/samplers/glsl-function-texture2dproj.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565.html
fast/canvas/webgl/texture-active-bind.html
fast/canvas/webgl/canvas-2d-webgl-texture.html
Comment 19 Build Bot 2013-07-18 12:28:32 PDT
Created attachment 207014 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 20 Gyuyoung Kim 2013-07-19 03:09:57 PDT
Created attachment 207075 [details]
WIP-7
Comment 21 Early Warning System Bot 2013-07-19 03:18:36 PDT
Comment on attachment 207075 [details]
WIP-7

Attachment 207075 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1104798
Comment 22 Early Warning System Bot 2013-07-19 03:19:24 PDT
Comment on attachment 207075 [details]
WIP-7

Attachment 207075 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1106825
Comment 23 Build Bot 2013-07-19 03:33:37 PDT
Comment on attachment 207075 [details]
WIP-7

Attachment 207075 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1104799
Comment 24 Build Bot 2013-07-19 03:45:45 PDT
Comment on attachment 207075 [details]
WIP-7

Attachment 207075 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1100735
Comment 25 Build Bot 2013-07-19 03:55:21 PDT
Comment on attachment 207075 [details]
WIP-7

Attachment 207075 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1110823
Comment 26 Gyuyoung Kim 2013-07-19 21:46:13 PDT
Created attachment 207181 [details]
WIP-8
Comment 27 Build Bot 2013-07-22 03:58:02 PDT
Comment on attachment 207181 [details]
WIP-8

Attachment 207181 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1080442

New failing tests:
fast/canvas/pattern-with-transform.html
webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html
webgl/conformance/extensions/oes-texture-float-with-canvas.html
canvas/philip/tests/2d.pattern.modify.canvas2.html
fast/canvas/webgl/tex-image-webgl.html
canvas/philip/tests/2d.pattern.paint.orientation.canvas.html
fast/canvas/canvas-pattern-behaviour.html
canvas/philip/tests/2d.pattern.modify.canvas1.html
http/tests/inspector/inspect-element.html
fast/canvas/webgl/texture-npot.html
canvas/philip/tests/initial.reset.pattern.html
webgl/conformance/textures/gl-teximage.html
webgl/conformance/context/premultiplyalpha-test.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551.html
editing/pasteboard/copy-image-with-alt-text.html
canvas/philip/tests/2d.pattern.basic.canvas.html
webgl/conformance/more/functions/texSubImage2DHTMLBadArgs.html
fast/canvas/webgl/tex-sub-image-2d-bad-args.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba4444.html
fast/canvas/webgl/premultiplyalpha-test.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565.html
fast/canvas/webgl/texture-active-bind.html
fast/canvas/webgl/canvas-2d-webgl-texture.html
Comment 28 Build Bot 2013-07-22 03:58:08 PDT
Created attachment 207238 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 29 Build Bot 2013-07-22 20:19:25 PDT
Comment on attachment 207181 [details]
WIP-8

Attachment 207181 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1139261
Comment 30 Build Bot 2013-07-31 16:40:38 PDT
Comment on attachment 207181 [details]
WIP-8

Attachment 207181 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1289908

New failing tests:
fast/canvas/webgl/premultiplyalpha-test.html
fast/canvas/pattern-with-transform.html
fast/canvas/canvas-pattern-modify.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565.html
fast/canvas/webgl/tex-sub-image-2d-bad-args.html
canvas/philip/tests/initial.reset.pattern.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba4444.html
canvas/philip/tests/2d.pattern.modify.canvas2.html
fast/css/font-face-data-uri.html
fast/canvas/webgl/tex-image-webgl.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551.html
fast/canvas/webgl/canvas-2d-webgl-texture.html
canvas/philip/tests/2d.pattern.paint.orientation.canvas.html
fast/canvas/canvas-pattern-behaviour.html
canvas/philip/tests/2d.pattern.modify.canvas1.html
canvas/philip/tests/2d.pattern.basic.canvas.html
http/tests/inspector/inspect-element.html
Comment 31 Build Bot 2013-07-31 16:40:42 PDT
Created attachment 207884 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.4
Comment 32 Michael Catanzaro 2017-03-11 10:37:21 PST
Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.