Bug 118449 - Remove unused variables in FocusCandidate.
Summary: Remove unused variables in FocusCandidate.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-06 23:49 PDT by Changhun Kang
Modified: 2013-07-08 14:06 PDT (History)
3 users (show)

See Also:

Attachments
Patch! (3.37 KB, patch)
2013-07-07 00:01 PDT, Changhun Kang 		no flags Details | Formatted Diff | Diff
Patch! (2.89 KB, patch)
2013-07-08 07:22 PDT, Changhun Kang 		no flags Details | Formatted Diff | Diff
Patch (2.41 KB, patch)
2013-07-08 09:31 PDT, Changhun Kang 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Changhun Kang 2013-07-06 23:49:36 PDT 
The variables for parent in FocusCandidate are not used anymore.
Comment 1 Changhun Kang 2013-07-07 00:01:04 PDT 
Created attachment 206204 [details]
Patch!
Comment 2 Antonio Gomes 2013-07-07 08:33:17 PDT 
Comment on attachment 206204 [details]
Patch!

Please fix your changelog.
Comment 3 Changhun Kang 2013-07-08 07:22:55 PDT 
Created attachment 206242 [details]
Patch!
Comment 4 WebKit Commit Bot 2013-07-08 07:57:17 PDT 
Comment on attachment 206242 [details]
Patch!

Rejecting attachment 206242 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 206242, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antonio Gomes']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Parsed 3 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
patch: **** unexpected end of file in patch
patching file Source/WebCore/page/SpatialNavigation.cpp
patching file Source/WebCore/page/SpatialNavigation.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antonio Gomes']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/1051003
Comment 5 Changhun Kang 2013-07-08 09:31:53 PDT 
Created attachment 206251 [details]
Patch
Comment 6 WebKit Commit Bot 2013-07-08 14:06:26 PDT 
Comment on attachment 206251 [details]
Patch

Clearing flags on attachment: 206251

Committed r152465: <http://trac.webkit.org/changeset/152465>
Comment 7 WebKit Commit Bot 2013-07-08 14:06:29 PDT 
All reviewed patches have been landed.  Closing bug.