Range.getClientRects() not working correctly for partially contained vertically styled text nodes

[Sam Weinig]

Created attachment 206197 [details]
Test Case

Range.getClientRects() is not working correctly for partially contained vertically styled text nodes.  (See attached test case).

[Sam Weinig]

Created attachment 206397 [details]
Potential fix from Mac Murrett

[Dave Hyatt]

Comment on attachment 206397 [details]
Potential fix from Mac Murrett

View in context: https://bugs.webkit.org/attachment.cgi?id=206397&action=review

> Source/WebCore/rendering/RenderText.cpp:338
>                  r.setHeight(box->logicalHeight());
>                  r.setY(box->y());
>              } else {
> -                r.setWidth(box->logicalWidth());
> +                r.setWidth(box->logicalHeight());
>                  r.setX(box->x());

Shouldn't this just be using box->width() and box->height()? Seems silly to call logical when you seem to want physical?

[Sam Weinig]

(In reply to comment #2)
> (From update of attachment 206397 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206397&action=review
> 
> > Source/WebCore/rendering/RenderText.cpp:338
> >                  r.setHeight(box->logicalHeight());
> >                  r.setY(box->y());
> >              } else {
> > -                r.setWidth(box->logicalWidth());
> > +                r.setWidth(box->logicalHeight());
> >                  r.setX(box->x());
> 
> Shouldn't this just be using box->width() and box->height()? Seems silly to call logical when you seem to want physical?

Agreed, I'll try that out.

[Sam Weinig]

Created attachment 206404 [details]
Patch

[Dave Hyatt]

Comment on attachment 206404 [details]
Patch

r=me

[Sam Weinig]

Committed r152554: <http://trac.webkit.org/changeset/152554>

[Daniel Bates]

<rdar://problem/14305675>