WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
118440
Tons of crashes on bots after
r152425
https://bugs.webkit.org/show_bug.cgi?id=118440
Summary
Tons of crashes on bots after r152425
Tim Horton
Reported
2013-07-05 21:31:35 PDT
In FrameView::max/minScrollPosition, m_frame->page() can be null (by design).
Attachments
patch
(2.34 KB, patch)
2013-07-05 21:36 PDT
,
Tim Horton
no flags
Details
Formatted Diff
Diff
patch
(2.76 KB, patch)
2013-07-05 21:50 PDT
,
Tim Horton
sam
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2013-07-05 21:32:53 PDT
<
rdar://problem/14366772
>
Tim Horton
Comment 2
2013-07-05 21:36:02 PDT
Created
attachment 206184
[details]
patch
Tim Horton
Comment 3
2013-07-05 21:50:17 PDT
Created
attachment 206185
[details]
patch
Sam Weinig
Comment 4
2013-07-05 21:53:32 PDT
Comment on
attachment 206185
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=206185&action=review
> Source/WebCore/page/FrameView.cpp:1646 > + if (Page* page = m_frame->page()) {
I would do an early return.
> Source/WebCore/page/FrameView.cpp:1658 > + Page* page = m_frame->page();
I would early return here.
Tim Horton
Comment 5
2013-07-05 22:03:29 PDT
http://trac.webkit.org/changeset/152434
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug