Bug 118428 - [Windows] Add logic to identify build-time feature set
Summary: [Windows] Add logic to identify build-time feature set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-05 10:49 PDT by Brent Fulgham
Modified: 2013-07-08 02:10 PDT (History)
12 users (show)

See Also:

Attachments
Patch (6.27 KB, patch)
2013-07-05 10:54 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Remove unrelated test result from previous patch. (5.86 KB, patch)
2013-07-05 10:56 PDT, Brent Fulgham 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-07-05 10:49:13 PDT 
Certain features are only present when building with newer SDK versions.  This patch adds a handful of tests to the build system to identify what OS level is being targeted so that only the features supported by the current build environment are integrated into WebKit.
Comment 1 Brent Fulgham 2013-07-05 10:54:31 PDT 
Created attachment 206161 [details]
Patch
Comment 2 Brent Fulgham 2013-07-05 10:56:53 PDT 
Created attachment 206162 [details]
Remove unrelated test result from previous patch.
Comment 3 Anders Carlsson 2013-07-05 13:50:40 PDT 
Comment on attachment 206162 [details]
Remove unrelated test result from previous patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=206162&action=review

> Source/WebCore/ChangeLog:9
> +        * WebCorePrefix.h: Activate MSVC 2010 workarounds for CGFLoat if

CGFloat.
Comment 4 Brent Fulgham 2013-07-05 14:43:19 PDT 
(In reply to comment #3)
> (From update of attachment 206162 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206162&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        * WebCorePrefix.h: Activate MSVC 2010 workarounds for CGFLoat if
> 
> CGFloat.

Done!
Comment 5 Brent Fulgham 2013-07-05 15:23:46 PDT 
Committed r152426: <http://trac.webkit.org/changeset/152426>
Comment 6 Zoltan Arvai 2013-07-08 02:10:08 PDT 
A buildfix landed for Qt Win in https://trac.webkit.org/changeset/152445.
WTFHeaderDetection.h is not generating on Qt Win.