Bug 118414 - Stop hardcoding interfaces that have indexed getters returning strings
Summary: Stop hardcoding interfaces that have indexed getters returning strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-05 07:21 PDT by Chris Dumez
Modified: 2013-07-06 00:25 PDT (History)
5 users (show)

See Also:

Attachments
WIP patch (2.25 KB, patch)
2013-07-05 07:22 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.26 KB, patch)
2013-07-05 07:52 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-07-05 07:21:43 PDT 
Interfaces that have indexed getters returning strings are currently hardcoded in the JSC bindings generator's IndexGetterReturnsStrings() subroutine.

Now that we support the latest Web IDL indexed getter format, the generator can be smarter and detect if the returned type is a DOMString on its own (since it is specified in the Web IDL).
Comment 1 Chris Dumez 2013-07-05 07:22:30 PDT 
Created attachment 206148 [details]
WIP patch
Comment 2 Chris Dumez 2013-07-05 07:52:57 PDT 
Created attachment 206151 [details]
Patch
Comment 3 Kentaro Hara 2013-07-05 17:11:16 PDT 
Comment on attachment 206151 [details]
Patch

ok
Comment 4 WebKit Commit Bot 2013-07-06 00:25:31 PDT 
Comment on attachment 206151 [details]
Patch

Clearing flags on attachment: 206151

Committed r152435: <http://trac.webkit.org/changeset/152435>
Comment 5 WebKit Commit Bot 2013-07-06 00:25:33 PDT 
All reviewed patches have been landed.  Closing bug.