Bug 118404 - TestWebKitFaviconDatabase/clear-database is not testing things properly
Summary: TestWebKitFaviconDatabase/clear-database is not testing things properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-04 19:58 PDT by Xabier Rodríguez Calvar
Modified: 2013-07-05 01:42 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.70 KB, patch)
2013-07-04 20:01 PDT, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2013-07-04 19:58:52 PDT 
TestWebKitFaviconDatabase/clean-database is not testing things properly
Comment 1 Xabier Rodríguez Calvar 2013-07-04 20:01:20 PDT 
Created attachment 206121 [details]
Patch

FiTest checks now for an existing icon and if clean database fails, it should exist and the test should fail. This was not happening so far.
Comment 2 WebKit Commit Bot 2013-07-04 20:03:28 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2013-07-04 22:46:58 PDT 
Comment on attachment 206121 [details]
Patch

Good catch, thanks! :-)
Comment 4 WebKit Commit Bot 2013-07-05 01:42:20 PDT 
Comment on attachment 206121 [details]
Patch

Clearing flags on attachment: 206121

Committed r152410: <http://trac.webkit.org/changeset/152410>
Comment 5 WebKit Commit Bot 2013-07-05 01:42:22 PDT 
All reviewed patches have been landed.  Closing bug.